Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all current ESPixelStick V4 Platform variants #3739

Closed
MartinMueller2003 opened this issue Mar 1, 2023 · 10 comments
Closed

Support all current ESPixelStick V4 Platform variants #3739

MartinMueller2003 opened this issue Mar 1, 2023 · 10 comments

Comments

@MartinMueller2003
Copy link
Contributor

I am getting defects reported in the ESPV4 project that indicate xLights is not configuring the ESP properly. As the platform list expands, people are generating custom mixes of supported features. All of these variants report as the same version (the base V4 version).

The current reccomended mechanism to determine the number of output ports and the capabilities of those ports is to read the config from the device and parse it. The config contains a complete list of capabilities and settings. The same is true for the input capabilities. FYI, this is how the browser UI works.

You can contact me at MartinMueller2003 on discord or on the red site.

@keithsw1111
Copy link
Collaborator

While you can include such settings in discovery they have to be in an xcontroller file for us to apply the rules. We cant be pulling this from the controller all the time as it wont always be online.

Our position on this is as follows. We will add xcontroller files to the distribution where there is sufficient volume in the market. We are not adding files for small scale boards. Instead we allow users to add their own xcontroller files to their install folder. Small scale vendors can directly distribute such files until they hit sufficient scale to make it sensible to add to xlights.

@MartinMueller2003
Copy link
Contributor Author

Thanks for the information. Do you have a pointer to the xcontroller format definitions?

@derwin12
Copy link
Collaborator

derwin12 commented Mar 3, 2023

Perhaps check the existing ones.
https://github.com/smeighan/xLights/tree/master/controllers

@computergeek1507
Copy link
Member

Is there a specific controller that is missing? Looking at the ESPixelstick issue tracker I didn't see anything related to this.

@MartinMueller2003
Copy link
Contributor Author

Just getting started on this, We are up to 23 platform variants. I looked in the esp controller file and it looks nicely expandable. It does not support everything V4 supports. I see generic serial is missing and most of the pixel types are not there either. Pixel type identifiers shift baased choicces made by yhe platform owner.

@keithsw1111
Copy link
Collaborator

Martin ... can you maybe put in a pull request with an updated xController file.

@MartinMueller2003
Copy link
Contributor Author

Can Do.

@cybercop23
Copy link
Collaborator

@MartinMueller2003 are there more that should be added to the list? If so, maybe you can do a PR and we can close this issue for now.

image

@MartinMueller2003
Copy link
Contributor Author

OK. I will update the list. This list has grown a lot since last April.

@cybercop23
Copy link
Collaborator

Thanks @MartinMueller2003. Best way to handle it, is to do a PR since you know all there's to know about the new models.
Please close this and replace it with a PR when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants