-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all current ESPixelStick V4 Platform variants #3739
Comments
While you can include such settings in discovery they have to be in an xcontroller file for us to apply the rules. We cant be pulling this from the controller all the time as it wont always be online. Our position on this is as follows. We will add xcontroller files to the distribution where there is sufficient volume in the market. We are not adding files for small scale boards. Instead we allow users to add their own xcontroller files to their install folder. Small scale vendors can directly distribute such files until they hit sufficient scale to make it sensible to add to xlights. |
Thanks for the information. Do you have a pointer to the xcontroller format definitions? |
Perhaps check the existing ones. |
Is there a specific controller that is missing? Looking at the ESPixelstick issue tracker I didn't see anything related to this. |
Just getting started on this, We are up to 23 platform variants. I looked in the esp controller file and it looks nicely expandable. It does not support everything V4 supports. I see generic serial is missing and most of the pixel types are not there either. Pixel type identifiers shift baased choicces made by yhe platform owner. |
Martin ... can you maybe put in a pull request with an updated xController file. |
Can Do. |
@MartinMueller2003 are there more that should be added to the list? If so, maybe you can do a PR and we can close this issue for now. |
OK. I will update the list. This list has grown a lot since last April. |
Thanks @MartinMueller2003. Best way to handle it, is to do a PR since you know all there's to know about the new models. |
I am getting defects reported in the ESPV4 project that indicate xLights is not configuring the ESP properly. As the platform list expands, people are generating custom mixes of supported features. All of these variants report as the same version (the base V4 version).
The current reccomended mechanism to determine the number of output ports and the capabilities of those ports is to read the config from the device and parse it. The config contains a complete list of capabilities and settings. The same is true for the input capabilities. FYI, this is how the browser UI works.
You can contact me at MartinMueller2003 on discord or on the red site.
The text was updated successfully, but these errors were encountered: