Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcon PiHat in .13 it shows the controller as having 4 ports when it only has 2. I had a friend try it and it's the same for them. I am using a windows pc #3948

Closed
iancooper65 opened this issue Aug 31, 2023 · 3 comments

Comments

@iancooper65
Copy link

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
(and/or link to a short video showing the problem with audio track describing what you are doing)

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen and why.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • OS: [e.g. Windows 10, Mac 10.14.5, etc...]
  • xLights version [e.g. 2019.37]

Additional context
Add any other context about the problem here.

Attachments

  • If associated with a crash please attach/link to a dropbox containing the crash log that was produced
  • If it crashed but no crash log was produced please use Tools Menu/Package Logs and attach/link to a dropbox containing the resulting zip file
  • If the error relates to rendering an effect or a crash while sequencing please use Tools Menu/Package Sequence and attach/link to a dropbox containing the resulting zip file

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.

@dartunder
Copy link
Contributor

The second two ports are shown in red to indicate invalid ports.
To my understanding, ports are added in groups of 4 as part of the logic to support long-range receivers.

Code Notes:
int UDController::GetSmartRemoteCount(int port) is creating 4 ports ...

In void ControllerModelDialog::ReloadModels() [ControllerModelDialog.cpp] check to see if the controller supports smart remotes or has more than 4 channels.

    if (pp != nullptr) {

        int currentSmartRemote = 0;
            
       int smartRemoteCount = 0;
        if ((_caps->SupportsSmartRemotes() > 0) || (_caps->GetMaxPixelPort() >= 4)) {
            smartRemoteCount = _cud->GetSmartRemoteCount(i + 1);            
        }

Seems to work but I'm unsure of the consequences of this change, but maybe it helps point you in the right direction.
Not sure if the _caps->GetMaxPixelPort() >= 4 is needed, but I was trying to be conservative.

@iancooper65
Copy link
Author

iancooper65 commented Sep 1, 2023 via email

@cybercop23
Copy link
Collaborator

@iancooper65 can this be closed? if so, can you please close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants