Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified and made consistent bash styles in install.sh #287

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Simplified and made consistent bash styles in install.sh #287

merged 5 commits into from
Feb 9, 2021

Conversation

raynix
Copy link
Contributor

@raynix raynix commented Feb 9, 2021

Description

Simplified and made consistent bash styles in install.sh

Checklist

  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • All pre-commit hook validation passed successfully.
  • All commits contain a well-written commit description including a title, description, and a Fixes: #XXX line if the commit addresses a particular GitHub issue.
  • All workflow validation and compliance checks are passing.

Issue Ref (Optional)

Which issue(s) this PR fixes (optional, using fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Notes

Add special notes for your reviewer here.

xunholy
xunholy approved these changes Feb 9, 2021
View reviewed changes
Copy link
Owner

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raynix happy to accept these changes, appreciate the contribution!

@xunholy
Copy link
Owner

xunholy commented Feb 9, 2021

CI is only failing due to running on a fork, still need to address that but PR can be merged.

@xunholy xunholy merged commit 8705f74 into xunholy:main Feb 9, 2021
@raynix
Copy link
Contributor Author

raynix commented Feb 9, 2021

Thanks @xunholy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xunholy xunholy xunholy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raynix @xunholy