Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MyPet needs to stop manually ticking WASD controllers without a rider #1425

Open
SmallSansSerif opened this issue Oct 28, 2020 · 3 comments
Open

MyPet needs to stop manually ticking WASD controllers without a rider #1425

SmallSansSerif opened this issue Oct 28, 2020 · 3 comments
Labels
Bug

Comments

@SmallSansSerif
Copy link

SmallSansSerif commented Oct 28, 2020 •
edited
Loading

MyPet is manually ticking WASD controllers without a rider. See PurpurMC/Purpur#64 (comment)

Bukkit/Spigot/Bungee Build/Version:
This server is running Purpur version git-Purpur-804 (MC: 1.16.3) (Implementing API version 1.16.3-R0.1-SNAPSHOT)
(Fork of Spigot/Paper/Tuinity)

MyPet Build/Version:
MyPet version 3.11

Error:
https://pastebin.com/YTmtV6tQ
ishland added a commit to YatopiaMC/Yatopia that referenced this issue Feb 1, 2021
@ishland
Fix NPE in ControllerLookWASD and ControllerMoveWASD
dcaccec 
Resolves #379
Resolves MyPetORG/MyPet#1425
@ishland ishland mentioned this issue Feb 1, 2021
Merged
ishland added a commit to YatopiaMC/Yatopia that referenced this issue Feb 3, 2021
@ishland
Fix NPE in ControllerLookWASD and ControllerMoveWASD (#380)
6f638c7 
Resolves #379
Related to MyPetORG/MyPet#1425
@BillyGalbreath
Copy link

I've pinpointed the issue. MyPet is overriding Entity#hasRider() from Purpur, making it appear there is a WASD rider when there is not.

https://github.com/xXKeyleXx/MyPet/blob/master/modules/v1_16_R3/src/main/java/de/Keyle/MyPet/compat/v1_16_R3/entity/EntityMyPet.java#L194-L197

@encode42 encode42 mentioned this issue Apr 11, 2021
Closed
@BillyGalbreath
Copy link

Since its apparent you have no plans to fix this in the plugin I went ahead and renamed the methods in Purpur to remove the conflict this plugin causes.

@scomans
Copy link
Member

scomans commented May 11, 2021

You could also send a PR to MyPet ;)

I'm not developing MyPet myself anymore that's why I never changed it. Sorry for that.

@luizsusin luizsusin mentioned this issue Jun 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BillyGalbreath @scomans @SmallSansSerif