Skip to content
This repository has been archived by the owner on Apr 13, 2020. It is now read-only.

Protection level of BeatPulseFilter + BeatPulseMiddleware #52

Closed
stephenpope opened this issue May 24, 2018 · 4 comments
Closed

Protection level of BeatPulseFilter + BeatPulseMiddleware #52

stephenpope opened this issue May 24, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@stephenpope
Copy link

stephenpope commented May 24, 2018

I am building an application (for sake of getting into pointless detail) I cant use the UseBeatPulse() Webhost extension.

I was hoping to be able register the IStartupFilter / BeatPulseFilter myself but this is private/internal.

So I thought I would register the middleware BeatPulseMiddleware myself but this is also private/internal.

Is there a reason for this level of security on these classes? I am keen to use BeatPulse but this has de-railed any progress I can make currently :)

@unaizorrilla
Copy link
Collaborator

Hi @stephenpope, this is not about "security", is about don't expose internal things. But, your are right, the BeatPulsePulseMiddleware should be public as asp.net usually does . In next version, probably tomorrow, I will make this change. Hope this help!

Thanks for fill this issue!!

Unai

@unaizorrilla unaizorrilla added the enhancement New feature or request label May 24, 2018
@unaizorrilla unaizorrilla self-assigned this May 24, 2018
@unaizorrilla
Copy link
Collaborator

unaizorrilla commented May 24, 2018

Fixed on 70de175 BeatPulseMiddleware is public from version 1.7.1

@stephenpope
Copy link
Author

Thanks for the quick fix :D

@unaizorrilla
Copy link
Collaborator

hope this help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants