Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Shared Element Transitions not working (v24.2.1-rc1) #16

Closed
dlmcdonald opened this issue Oct 13, 2016 · 11 comments
Closed

Shared Element Transitions not working (v24.2.1-rc1) #16

dlmcdonald opened this issue Oct 13, 2016 · 11 comments
Assignees

Comments

@dlmcdonald
Copy link

Xamarin.Android Version (eg: 6.0):

7.0.1.3

Operating System & Version (eg: Mac OSX 10.11):

Windows 10

Support Libraries Version (eg: 23.3.0):

v24.2.1-rc1

Describe your Issue:

I updated to the alpha nuget package to test out the DiffUtils when I noticed that my shared transition elements were not animating any more. This was still working on the stable package. I understand that this is obviously still in alpha, but I just wanted to check if you were aware of the issue

Steps to Reproduce (with link to sample solution if possible):

I just used a very basic empty sample with the following code to navigate from one activity to the second activity:
Pair participant = new Pair(imgImage, ViewCompat.GetTransitionName(imgImage));
var opts = ActivityOptionsCompat.MakeSceneTransitionAnimation(this, participant);
Intent detailsIntent = new Intent(this, typeof(SecondActivity));
StartActivity(detailsIntent, opts.ToBundle());

Include any relevant Exception Stack traces, build logs, adb logs:

@jasonctoms
Copy link

I believe this issue still exists in the stable release of 24.2.1. See my StackOverflow question here.

@Redth
Copy link
Member

Redth commented Jan 26, 2017

I've been able to reproduce this locally now. I'm going to have to do some digging to see why it would work on java but not in our bindings, this is something that we don't usually see (where the behaviour is different from the binding to the java usage)...

@Redth Redth self-assigned this Jan 26, 2017
@Redth Redth added the bug label Jan 26, 2017
@Redth
Copy link
Member

Redth commented Jan 26, 2017

@jasonctoms @dlmcdonald I can't reproduce it working on 23.3.0 stable version. Do either of you have a known working example of this on an older package version?

@jasonctoms
Copy link

@Redth I cannot post a full project because the code is for work and not open source. But the snippet in my stack overflow post is a pretty normal shared element transition. Pressing on a webview launching an intent to an activity that is just a full screen webview. On 23.3.0 the webview properly expanded to fill the screen. But now it just looks like a normal activity transition, with the full screen changing. I have confirmed in debugging that the shared element options code is being executed, it just doesn't seem to have any effect.

@Redth
Copy link
Member

Redth commented Jan 26, 2017

I'm using a simple example of transitioning from a smaller ImageView to a bigger one on the second activity. In my java app it works fine, on Xamarin it does not, not even with 23.3.0 which is why I ask for a 'working' example since I can't reproduce it ever working.

@dlmcdonald
Copy link
Author

@Redth I have an example project that I initially used to test this. I can also confirm that it does not work using 23.3.0, however, using 23.4.0.1, it does definitely work. If you are unable to get it to work using that version of the library, let me know and I can send you my working example

@jasonctoms
Copy link

@Redth I am sorry I was mistaken. I had previously been using 23.4.0.1 when it worked too, not 23.3.0.

@csdinon
Copy link

csdinon commented Feb 25, 2017

possibly related to this bug? https://bugzilla.xamarin.com/show_bug.cgi?id=40527
This looks to be caused by ActivityOptionsCompat.ToBundle() returning null.

@Redth
Copy link
Member

Redth commented Apr 3, 2017

This should be working in 25.3.1-beta1, I can no longer reproduce the issue with this version.

@Redth Redth closed this as completed Apr 3, 2017
@mattleibow
Copy link
Contributor

@Redth I think this is still an issue :( Hopefully I am doing something wrong, but this is what I have so far.

This is the C# code: https://github.com/mattleibow/SharedElementTransitions
This is the Java code: https://github.com/obaro/SharedElementTransitions

I think I coped the code exactly (almost), but the transitions are not working at all. I am using the v25.4.0.1 packages.

@mattleibow
Copy link
Contributor

I just wanted to leave a comment. For some reason, this works totally fine when the minSdkVersion is set to API 14+ (v4.0+). As soon as I drop it, nothing works...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants