Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-291: Rename to MainThread for threading calls #325

Merged
merged 4 commits into from Jun 25, 2018

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Describe your changes here.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

Changed from Platform to MainThread and updated all samples/docs

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Jun 25, 2018
@jamesmontemagno jamesmontemagno added this to the 0.8.0-preview milestone Jun 25, 2018
@dend
Copy link
Contributor

dend commented Jun 25, 2018

❌ Validation status: errors

File Status Preview URL Details
❌Error Details

  • [Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/xamarin/Essentials, working directory: W:\ovpj-s, target branch: master, target branch commit: b05a266, source branch: bug/issue-291, source branch commit: .

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Contributor

dend commented Jun 25, 2018

❌ Validation status: errors

File Status Preview URL Details
❌Error Details
❌Error Details

  • [Error] Failed to load 2 files, aborting...
  • [Error] System.IO.FileNotFoundException: File not found.
    File name: 'W:\fbfv-log-6758c10b\change-list-with-redirection.mapped.tsv'
    at Microsoft.DocAsCode.Build.Engine.Incrementals.ChangeList.Parse(String tsvFile, String baseDir)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()
  • Line 80: [Warning] Failed to run script W:\fbfv-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

  • [Error] Failed to load 2 files, aborting...
  • [Error] System.IO.FileNotFoundException: File not found.
    File name: 'W:\fbfv-log-6758c10b\change-list-with-redirection.mapped.tsv'
    at Microsoft.DocAsCode.Build.Engine.Incrementals.ChangeList.Parse(String tsvFile, String baseDir)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
    at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()
  • Line 80: [Warning] Failed to run script W:\fbfv-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mattleibow
Copy link
Contributor

The 'Member' start tag on line 18 position 6 does not match the end tag of 'remarks'. Line 39, position 30.
The 'Type' start tag on line 1 position 2 does not match the end tag of 'Members'. Line 94, position 5.

@dend
Copy link
Contributor

dend commented Jun 25, 2018

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Android/Resources/Resource.designer.cs ✅Succeeded
DeviceTests/DeviceTests.Shared/DeviceTests.Shared.projitems ✅Succeeded
DeviceTests/DeviceTests.Shared/MainThread_Tests.cs ✅Succeeded
Samples/Samples.Android/Resources/Resource.designer.cs ✅Succeeded
Samples/Samples/ViewModel/AccelerometerViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/CompassViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/GyroscopeViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/MagnetometerViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/OrientationSensorViewModel.cs ✅Succeeded
Xamarin.Essentials/Accelerometer/Accelerometer.shared.cs ✅Succeeded
Xamarin.Essentials/Battery/Battery.ios.cs ✅Succeeded
Xamarin.Essentials/Battery/Battery.uwp.cs ✅Succeeded
Xamarin.Essentials/Compass/Compass.shared.cs ✅Succeeded
Xamarin.Essentials/Connectivity/Connectivity.shared.cs ✅Succeeded
Xamarin.Essentials/DeviceDisplay/DeviceDisplay.uwp.cs ✅Succeeded
Xamarin.Essentials/Gyroscope/Gyroscope.shared.cs ✅Succeeded
Xamarin.Essentials/Magnetometer/Magnetometer.shared.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.android.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.ios.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.netstandard.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.shared.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThreadExtensions.uwp.cs ✅Succeeded
Xamarin.Essentials/OrientationSensor/OrientationSensor.shared.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.android.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.ios.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.shared.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.uwp.cs ✅Succeeded
Xamarin.Essentials/mdoc.targets ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/MainThread.xml ✅Succeeded
docs/en/Xamarin.Essentials/Platform.xml ✅Succeeded
docs/en/index.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Contributor

dend commented Jun 25, 2018

✅ Validation status: passed

File Status Preview URL Details
DeviceTests/DeviceTests.Android/Resources/Resource.designer.cs ✅Succeeded
DeviceTests/DeviceTests.Shared/DeviceTests.Shared.projitems ✅Succeeded
DeviceTests/DeviceTests.Shared/MainThread_Tests.cs ✅Succeeded
Samples/Samples.Android/Resources/Resource.designer.cs ✅Succeeded
Samples/Samples/ViewModel/AccelerometerViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/CompassViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/GyroscopeViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/MagnetometerViewModel.cs ✅Succeeded
Samples/Samples/ViewModel/OrientationSensorViewModel.cs ✅Succeeded
Xamarin.Essentials/Accelerometer/Accelerometer.shared.cs ✅Succeeded
Xamarin.Essentials/Battery/Battery.ios.cs ✅Succeeded
Xamarin.Essentials/Battery/Battery.uwp.cs ✅Succeeded
Xamarin.Essentials/Compass/Compass.shared.cs ✅Succeeded
Xamarin.Essentials/Connectivity/Connectivity.shared.cs ✅Succeeded
Xamarin.Essentials/DeviceDisplay/DeviceDisplay.uwp.cs ✅Succeeded
Xamarin.Essentials/Gyroscope/Gyroscope.shared.cs ✅Succeeded
Xamarin.Essentials/Magnetometer/Magnetometer.shared.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.android.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.ios.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.netstandard.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.shared.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded
Xamarin.Essentials/MainThread/MainThreadExtensions.uwp.cs ✅Succeeded
Xamarin.Essentials/OrientationSensor/OrientationSensor.shared.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.android.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.ios.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.shared.cs ✅Succeeded
Xamarin.Essentials/Platform/Platform.uwp.cs ✅Succeeded
Xamarin.Essentials/mdoc.targets ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/MainThread.xml ✅Succeeded
docs/en/Xamarin.Essentials/Platform.xml ✅Succeeded
docs/en/index.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno
Copy link
Collaborator Author

should be good now @Redth @mattleibow copy/paste errors on my end.

@jamesmontemagno jamesmontemagno merged commit 77f9328 into master Jun 25, 2018
@jamesmontemagno jamesmontemagno deleted the bug/issue-291 branch June 26, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR needs to have a set of eyes on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants