Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-231: Implement Open Settings for all platforms #328

Merged
merged 2 commits into from Jun 25, 2018
Merged

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Added API to open app settings

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • void AppInfo.OpenSettings();

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Jun 25, 2018
@jamesmontemagno jamesmontemagno added this to the 0.8.0-preview milestone Jun 25, 2018
@dend
Copy link
Contributor

dend commented Jun 25, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/AppInfoPage.xaml ✅Succeeded
Samples/Samples/ViewModel/AppInfoViewModel.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.android.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.ios.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.netstandard.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.shared.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/AppInfo.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Contributor

dend commented Jun 25, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/AppInfoPage.xaml ✅Succeeded
Samples/Samples/ViewModel/AppInfoViewModel.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.android.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.ios.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.netstandard.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.shared.cs ✅Succeeded
Xamarin.Essentials/AppInfo/AppInfo.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/AppInfo.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth Redth merged commit 533a4d7 into master Jun 25, 2018
@Redth Redth deleted the feature/issue-231 branch June 25, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR needs to have a set of eyes on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants