Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix navigating/navigated events and add ".." navigation #10048

Merged
merged 1 commit into from Mar 27, 2020
Merged

Fix navigating/navigated events and add ".." navigation #10048

merged 1 commit into from Mar 27, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Mar 21, 2020 •
edited

Description of Change

  • Fix Navigating/Navigated/OnNavigating/OnNavigated so they fire the correct number of times
  • Process ".." navigation as going back one url path

Issues Resolved

Platforms Affected

  • Core/XAML (all platforms)

Testing Procedure

Unit tests included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Mar 21, 2020
@PureWeen PureWeen added this to To do in v4.6.0 via automation Mar 21, 2020
@PureWeen PureWeen added this to the 4.6.0 milestone Mar 21, 2020
@samhouts samhouts removed this from To do in v4.6.0 Mar 21, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 21, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 21, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts removed this from In Review in v4.6.0 Mar 22, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 29, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 29, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
@samhouts samhouts removed this from Done in v4.6.0 Mar 30, 2020
@samhouts samhouts added this to Done in v4.6.0 Mar 30, 2020
This was referenced Mar 31, 2020
Closed
Closed
@samhouts samhouts added this to Done in Shell Apr 10, 2020
@samhouts samhouts added this to Done in Sprint 168 Apr 30, 2020
@samhouts samhouts removed this from Done in Shell May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

Assignees
No one assigned
Labels
a/navigation a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core t/bug 🐛
Projects
No open projects
Sprint 168
  
Done
v4.6.0
  
Done
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @StephaneDelcroix @samhouts