Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Setting Shell.PresentationMode=ModalAnimated does not hide NavigationBar on ModalPage #10309

Open
HobDev opened this issue Apr 12, 2020 · 7 comments

Comments

@HobDev
Copy link

HobDev commented Apr 12, 2020

Reproduction Link

ShellNavigationSample.zip

Workaround

Set Shell.NavBarIsVisible ="False".

@HobDev HobDev added s/unverified New report that has yet to be verified t/bug 🐛 labels Apr 12, 2020
@pauldipietro pauldipietro added this to New in Triage Apr 12, 2020
@jsuarezruiz
Copy link
Contributor

@HobDev If you use GoToAsync (in combination with Modal PresentationMode) it will push modally so the page will be modal. In other case, for example, using PushAsync will not have any effect.

@jsuarezruiz jsuarezruiz added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Apr 20, 2020
@jsuarezruiz jsuarezruiz moved this from New to Needs Info in Triage Apr 20, 2020
@HobDev
Copy link
Author

HobDev commented Apr 21, 2020

@jsuarezruiz I want to present the LoginPage as Modal. LoginPage is first and current item of the shell on app startup. So, I don't have to use GoToAsync or PushModalAsync. I just need to set PresentationMode to Modal.

@HobDev
Copy link
Author

HobDev commented Apr 21, 2020

I didn't tested the Modal Presentation with other pages in the Shell.

@samhouts samhouts removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Apr 22, 2020
@samhouts samhouts moved this from Needs Info to New in Triage Apr 22, 2020
@jsuarezruiz
Copy link
Contributor

@PureWeen I would like to have your opinion in this case.

@jsuarezruiz jsuarezruiz moved this from New to Needs Info in Triage Apr 24, 2020
@jsuarezruiz jsuarezruiz added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Apr 24, 2020
@HobDev
Copy link
Author

HobDev commented May 2, 2020

Any updates on this

@samhouts samhouts added this to Backlog in Shell May 5, 2020
@samhouts samhouts removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label May 8, 2020
@samhouts samhouts moved this from Needs Info to New in Triage May 8, 2020
@PureWeen
Copy link
Contributor

@HobDev If I'm understanding your scenario here you're wanting the LoginPage to be specified in the AppShell file.

It'll be the first page that loads and it'll load modally?

Currently the presentation mode only works for pages you are pushing onto the stack but just making sure I'm following your sample

@HobDev
Copy link
Author

HobDev commented May 19, 2020

@PureWeen Exactly, I want to load LoginPage modally and it is specified in AppShell.

Additionally I am curious to know the difference between ModalPage and ContentPage with hidden NavBar. It seems to me that ModalPage is also hiding the NavBar. I didn't notice any other difference.

@rmarinho rmarinho removed the s/unverified New report that has yet to be verified label May 21, 2020
@rmarinho rmarinho moved this from New to Needs Estimate in Triage May 21, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 13, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Shell
  
Backlog
Triage
  
Needs Estimate
Development

No branches or pull requests

5 participants