Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Styling issues with FlyoutItem classes #10382

Closed
davidortinau opened this issue Apr 20, 2020 · 2 comments
Closed

[Bug] Styling issues with FlyoutItem classes #10382

davidortinau opened this issue Apr 20, 2020 · 2 comments
Labels
in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects

Comments

@davidortinau
Copy link
Contributor

davidortinau commented Apr 20, 2020

Description

I'm using the new classes to style the FlyoutItem menu items.

  • FlyoutItemLabelStyle
  • FlyoutItemImageStyle
  • FlyoutItemLayoutStyle

Few issues:

  • Label doesn't update according to state changes, such as Selected, while the background does
  • Cannot style the color of the icons - I'm using FontImageSource and only want to change the color
  • Cannot use a custom style class to chain them on FlyoutItems as shown in the PR Propagating StyleClass on ShellElements to Flyout templates #9886

Please support propagation of states to children or provide a similar solution to style all the elements of the flyout item templates and menu items.

Basic Information

  • Version with issue: 4.6-pre4
  • Platform Target Frameworks:
    • iOS: 13.2

Reproduction Link

https://github.com/davidortinau/FlyMe/blob/bug/flyout-styling/FlyMe/FlyMe/AppShell.xaml#L14

Workaround

I suppose I could create my own template putting the VSM on the layout and use the new Target property to update all elements of the template.

@davidortinau davidortinau added t/bug 🐛 s/unverified New report that has yet to be verified labels Apr 20, 2020
@pauldipietro pauldipietro added this to New in Triage Apr 20, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Apr 20, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Apr 20, 2020
@samhouts samhouts removed this from New in Triage Apr 20, 2020
@PureWeen PureWeen moved this from In Progress to In Review in v4.6.0 Apr 20, 2020
@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Apr 20, 2020
@PureWeen PureWeen added this to Backlog in Shell via automation Apr 20, 2020
@PureWeen PureWeen moved this from Backlog to In Review in Shell Apr 20, 2020
@samhouts samhouts moved this from In Review to Done in v4.6.0 Apr 21, 2020
Shell automation moved this from In Review to Done Apr 23, 2020
@dishantmshah
Copy link

dishantmshah commented May 18, 2020

@davidortinau I am still able to reproduce this issue in Android with the latest version of Xamarin.Forms.

FlyoutItemGridStyle class is not updating any of the mentioned styles. Even setting Selected item BackgroundColor via VSM is not working.

Version Details:

Xamarin.Forms - 4.6.0.772
Xamarin.Android - 9.2.3.0
Visual Studio - 8.3.1 (build 18)

@samhouts samhouts removed this from Done in Shell May 23, 2020
@PureWeen
Copy link
Contributor

@dishantmshah FlyoutItemGridStyle was renamed to FlyoutItemLayoutStyle

https://docs.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/shell/flyout#flyoutitem-and-menuitem-style-classes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
No open projects
v4.6.0
  
Done
Development

No branches or pull requests

4 participants