This repository has been archived by the owner on May 1, 2024. It is now read-only.
Runtime updating of AppTheme values #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/bug 🐛
blocker
jfversluis
commented
Apr 24, 2020
| @@ -275,8 +275,7 @@ void SetEffectiveFlowDirection(EffectiveFlowDirection value, bool fireFlowDirect | |||
|
|
|||
| internal VisualElement() | |||
| { | |||
| if (Device.Flags?.IndexOf(ExperimentalFlags.AppThemeExperimental) > 0) | |||
There was a problem hiding this comment.
This one was removed intentionally. It caused some unexpected behavior
jfversluis
added
the
API-change
jfversluis
force-pushed
the
apptheme-runtimeupdate
branch
from
5ba893e
to
eaa2fae
Compare
PureWeen
suggested changes
Apr 24, 2020
PureWeen
approved these changes
Apr 27, 2020
samhouts
suggested changes
Apr 28, 2020
|
Nice one! Was due to the experimental flag validation while raising the event. Should be fixed now 🤞 |
samhouts
approved these changes
Apr 28, 2020
| @@ -274,7 +275,7 @@ | |||
| <ItemGroup /> | |||
| <Target Name="_CopyNUnitTestAdapterFiles" AfterTargets="Build"> | |||
| <ItemGroup> | |||
| <_NUnitTestAdapterFiles Include="$(NuGetPackageRoot)NUnit3TestAdapter\%(Version)\build\net35\**" Condition="@(PackageReference -> '%(Identity)') == 'NUnit3TestAdapter'" InProject="False" /> | |||
There was a problem hiding this comment.
Uh. No. But it's added again on the next line but it just escapes the > to a gt;. I'm guessing that's an inconsistency between VS versions/VSWin and VSMac? I'll revert to be sure
This was referenced May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This implements the runtime updating of AppTheme values.
Issues Resolved
API Changes
Added:
Platforms Affected
Behavioral/Visual Changes
The
INotifyPropertyChangedwas removed from the API. It doesn't make much sense to have that on there (anymore). People that were using that might see breaks.Before/After Screenshots
iOS
Android
Testing Procedure
Go to the right gallery page(s) and switch appearance
PR Checklist