Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] CollectionView Header Controls with Commands Don't work when EmptyView is Visible #10477

Closed
jamesmontemagno opened this issue Apr 27, 2020 · 3 comments
Assignees
Labels
a/collectionview e/4 🕓 4 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects

Comments

@jamesmontemagno
Copy link
Contributor

Description

When you have a collectionview with a header with a button (or other elements) that have events/commands and put in an empty view in (and it is visible) the events dont' fire.

Steps to Reproduce

  1. See repro and screenshots

Expected Behavior

Events in header should still fire

Actual Behavior

They don't currently fire :(

Basic Information

  • Version with issue: 4.6.-pre4
  • Last known good version: ?
  • IDE: VS 2019 16.5
  • Platform Target Frameworks:
    • iOS: Not tested
    • Android: Android 9 tested
    • UWP: Not Tested
  • Android Support Library Version: 28.0.0.3
  • Nuget Packages:
  • Affected Devices:

Screenshots

Untitled Project

Reproduction Link

App14.zip

Workaround

Don't' use emptyview

@jamesmontemagno jamesmontemagno added t/bug 🐛 s/unverified New report that has yet to be verified labels Apr 27, 2020
@pauldipietro pauldipietro added this to New in Triage Apr 27, 2020
@hartez hartez added e/4 🕓 4 s/unverified New report that has yet to be verified and removed s/unverified New report that has yet to be verified labels Apr 29, 2020
@hartez hartez added this to Backlog in CollectionView via automation Apr 29, 2020
@hartez hartez removed this from New in Triage Apr 29, 2020
@hartez
Copy link
Contributor

hartez commented Apr 29, 2020

If I set the Command on the button directly (rather than using binding), it works fine. It looks like the EmptyView is messing with the header's BindingContext.

@jamesmontemagno
Copy link
Contributor Author

interesting..... do you think I should set the bindingcontext manually somehow?

@jsuarezruiz jsuarezruiz removed the s/unverified New report that has yet to be verified label May 15, 2020
@jsuarezruiz jsuarezruiz self-assigned this May 15, 2020
@jsuarezruiz jsuarezruiz moved this from Backlog to In Progress in CollectionView May 15, 2020
@jsuarezruiz
Copy link
Contributor

@jamesmontemagno Thanks for the reproduction sample. This PR will fix this issue: #10705

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label May 28, 2020
CollectionView automation moved this from In Progress to Done Jun 17, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 20, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 20, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 20, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 20, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 20, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jun 29, 2020
@samhouts samhouts removed this from Done in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 1, 2020
@samhouts samhouts removed this from In Progress in 4.7.0 Jul 1, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 1, 2020
@samhouts samhouts removed this from Done in CollectionView Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/collectionview e/4 🕓 4 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
No open projects
v4.6.0
  
Done
Development

No branches or pull requests

4 participants