Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] CarouselView on Android does not always fire CurrentItemChanged or PositionChanged when scrolling #10775

Closed
chrisstaley opened this issue May 19, 2020 · 3 comments · Fixed by #10850
Closed

[Bug] CarouselView on Android does not always fire CurrentItemChanged or PositionChanged when scrolling #10775

chrisstaley opened this issue May 19, 2020 · 3 comments · Fixed by #10850
Assignees
@rmarinho
Labels
a/carouselview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/4 🕓 4 p/Android t/bug 🐛
Projects
Sprint 170 Sprint 171 v4.6.0

Comments

@chrisstaley
Copy link

Description

CarouselView will not always fire the CurrentItemChanged or PositionChanged events when scrolling in certain situations on Android. iOS works as expected. See the attached repro project.

There appears to be a threshold point at which PeekAreaInsets can be set beyond which the aforementioned events will not fire. I'm assuming the threshold may have to do with some combination of the rendered item's width, the layout's ItemSpacing, and the width of the screen (in pixels). The attached repro project was tested on an emulator based off of the Pixel 3 XL's screen dimensions.

Steps to Reproduce

  1. Run the repro project.
  2. Scroll the bottom CarouselView back and forth.
  3. Note that neither CurrentItemChanged nor PositionChanged is ever called.

Expected Behavior

CurrentItemChanged and PositionChanged should both be called any time the items scroll.

Basic Information

  • Version with issue: 4.6.0.800

Reproduction Link

CarouselViewIssue.zip
@chrisstaley chrisstaley added s/unverified New report that has yet to be verified t/bug 🐛 labels May 19, 2020
@pauldipietro pauldipietro added this to New in Triage May 19, 2020
@rmarinho rmarinho moved this from New to Ready For Work in Triage May 19, 2020
@rmarinho rmarinho added this to Backlog in CarouselView via automation May 19, 2020
@rmarinho rmarinho added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android a/carouselview e/4 🕓 4 and removed s/unverified New report that has yet to be verified labels May 19, 2020
@samhouts samhouts added this to To do in Sprint 170 May 20, 2020
@samhouts samhouts added this to To do in Sprint 171 May 21, 2020
@samhouts samhouts moved this from To do to Continued in next sprint in Sprint 170 May 26, 2020
@rmarinho rmarinho mentioned this issue May 27, 2020
Merged
2 tasks
@rmarinho
Copy link
Member

Hey @chrisstaley can you try this nuget
Xamarin.Forms.4.6.0.2756.zip

@rmarinho rmarinho linked a pull request May 27, 2020 that will close this issue
[Android] Fix changing CarouselView using CurrentItem #10838
Merged
2 tasks
@rmarinho rmarinho self-assigned this May 27, 2020
@rmarinho rmarinho moved this from Backlog to In Progress in CarouselView May 27, 2020
@rmarinho rmarinho moved this from To do to In progress in Sprint 171 May 27, 2020
@rmarinho rmarinho linked a pull request May 27, 2020 that will close this issue
[Android] Update CurrentItem when swiping #10850
Merged
2 tasks
@rmarinho rmarinho removed a link to a pull request May 27, 2020
[Android] Fix changing CarouselView using CurrentItem #10838
Merged
2 tasks
@chrisstaley
Copy link
Author

@rmarinho That appears to have fixed the issue. Thanks!

Triage automation moved this from Ready For Work to Closed May 28, 2020
CarouselView automation moved this from In Progress to Done May 28, 2020
Sprint 171 automation moved this from In progress to Done May 28, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jun 20, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jun 20, 2020
@samhouts samhouts removed this from Closed in Triage Jun 27, 2020
@samhouts samhouts removed this from Done in CarouselView Jun 27, 2020
@divyesh008
Copy link

I am still facing this same issue in Xamarin.Forms 5.0, means it's not fixed yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rmarinho rmarinho

Labels
a/carouselview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/4 🕓 4 p/Android t/bug 🐛
Projects
No open projects
Sprint 170
  
Continued in next sprint
Sprint 171
  
Done
v4.6.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Update CurrentItem when swiping xamarin/Xamarin.Forms
3 participants
@rmarinho @chrisstaley @divyesh008