Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell keeps showing menu button in navbar instead of back button in 4.7 #11102

Closed
jtorvald opened this issue Jun 18, 2020 · 10 comments
Closed

[Bug] Shell keeps showing menu button in navbar instead of back button in 4.7 #11102

jtorvald opened this issue Jun 18, 2020 · 10 comments
Assignees
@PureWeen
Labels
4.7.0 regression on 4.7.0 a/shell 🐚 i/regression in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 s/unverified New report that has yet to be verified t/bug 🐛
Projects
4.7.0
Milestone
4.7.0

Comments

@jtorvald
Copy link
Contributor

Description

My code in 4.5 and 4.6 worked fine, but now after upgrading to 4.7 the back button does not show when navigating to a page (iOS). It keeps showing the menu icon (hamburger for the flyout) on every page.

This is probably a terrible bug report because I can't share screenshots/code and can not reproduce it in a new solution with Xamarin Forms 4.7.

Just wanted to file it and I'm hoping that someone can point me in the right direction on how to debug this. Downgrading to 4.6 makes the issue go away.

Steps to Reproduce

I tried to create an example project but there it seems to work

Expected Behavior

Show back on navigating to a page with Shell.Current.GoToAsync or Navigation.PushAsync

Actual Behavior

Shows flyout menu icon

Basic Information

  • Version with issue: 4.7
  • Last known good version: 4.6
@jtorvald jtorvald added s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 18, 2020
@pauldipietro pauldipietro added this to New in Triage Jun 18, 2020
@samhouts samhouts added this to the 4.7.0 milestone Jun 18, 2020
@PureWeen
Copy link
Contributor

@jtorvald are you using BackButtonBehavior on any of your pages?

@samhouts samhouts added this to To do in 4.7.0 Jun 20, 2020
@jtorvald
Copy link
Contributor Author

@PureWeen yeah in two login pages but they are not 'hit' in the flow since I'm already logged in and I load a different AppShell on start for logged in users.

@PureWeen
Copy link
Contributor

PureWeen commented Jun 26, 2020 •
edited
Loading

@jtorvald can you post your XAML file with shell?

How/where do you initialize Shell as the main page?
Can you post the code you are using to navigate ?

Are you setting FlyoutBehavior anywhere?

@PureWeen PureWeen mentioned this issue Jul 1, 2020
Merged
2 tasks
@PureWeen
Copy link
Contributor

PureWeen commented Jul 1, 2020

@jtorvald I'm going to mark this one fixed by this PR

#11264

Once that's merged if you're still seeing the issue please let me know

@jtorvald
Copy link
Contributor Author

jtorvald commented Jul 1, 2020

@PureWeen thanks. Sorry but I didn't have time to supply the requested info yet. It's also not urgent so I will await the new fix and let you know with more details in case it doesn't fix it. Thanks for you time looking into this.

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jul 1, 2020
@PureWeen
Copy link
Contributor

PureWeen commented Jul 2, 2020

@jtorvald

Here are the nugets from this PR if you'd like to test
https://dev.azure.com/xamarin/public/_build/results?buildId=21694&view=artifacts&type=publishedArtifacts

@samhouts samhouts moved this from New to Ready For Work in Triage Jul 2, 2020
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Jul 2, 2020
@jtorvald
Copy link
Contributor Author

@PureWeen I figured it out: I had FlyoutIcon="hamburger.png". I've been developing this app for a while and in the previous xamarin forms versions it was not an issue. Now apparently it is for some reason. Since I'm happy with the default icon I can just remove the attribute, but just wanted to update this issue here with the cause. Not sure if that is expected behavior or not.

@PureWeen
Copy link
Contributor

@jtorvald Aw ok yea I'd say that's a bug

Thank you for checking back in!!

@PureWeen PureWeen added this to Backlog in Shell via automation Jul 10, 2020
@PureWeen PureWeen moved this from Backlog to To do (blockers) in Shell Jul 10, 2020
@PureWeen PureWeen moved this from Needs Estimate to Ready For Work in Triage Jul 10, 2020
@samhouts samhouts moved this from To do (blockers) to In Progress in Shell Jul 10, 2020
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Jul 13, 2020
@samhouts samhouts moved this from To do to Done in 4.7.0 Jul 16, 2020
Triage automation moved this from Needs Estimate to Closed Jul 20, 2020
Shell automation moved this from In Progress to Done Jul 20, 2020
@gresolio
Copy link

After upgrading to 4.7.0.1179, shell back button icon disappeared in all views, which previously worked just fine with following options:

Shell.TabBarIsVisible="false"
Shell.FlyoutBehavior="Disabled"

Downgrading to 4.7.0.1142 fixes this rather unpleasant issue.

I read the Release Notes 4.7.0.1179 and found the back button is mentioned here.
Is this expected behaviour? (and we should update our project to work with the new version of Xamarin.Forms). Or is it a bug?

@PureWeen
Copy link
Contributor

@gresolio that will be fixed by the next PR

@samhouts samhouts removed this from Closed in Triage Aug 19, 2020
@samhouts samhouts removed this from Done in Shell Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PureWeen PureWeen

Labels
4.7.0 regression on 4.7.0 a/shell 🐚 i/regression in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 s/unverified New report that has yet to be verified t/bug 🐛
Projects
No open projects
4.7.0
  
Done
Milestone
4.7.0
Development

No branches or pull requests
4 participants
@jtorvald @gresolio @PureWeen @samhouts