[Bug] Windows Platform-Specifics : Page.ToolbarPlacement not working on Modal pages

[mhrastegari]

Description

i set the Page.ToolbarPlacement to Bottom in a modal page and it seems it doesn't work, plus it looks like intellisense doesn't know about it.

Steps to Reproduce

1. add windows:Page.ToolbarPlacement="Bottom" to 2nd page
2. and navigate to the page using PushModalAsync

Expected Behavior

Page.ToolbarPlacement work on modal pages.

Basic Information

• Version with issue: 4.7
• Last known good version: Unknown
• IDE: Visual Studio 16.6.2
• UWP: TargetVersion: 10.0.18362.0 TargetMinVersion: 10.0.17763.0

Screenshots

[EmilAlipiev]

How did you place the text horizontally?

[mhrastegari]

you can easily do this with the following in the App.xaml in your UWP project

<Application
  xmlns:uwp="using:Xamarin.Forms.Platform.UWP">
    <Application.Resources>
        <ResourceDictionary>
            <Style TargetType="uwp:FormsCommandBar">
                <Setter Property="DefaultLabelPosition" Value="Right"/>
            </Style>
        </ResourceDictionary>
    </Application.Resources>
</Application>

[rmarinho]

Hi @mhrastegary77 can you please helps by providing a small sample for us.

Are these 2 issues ?
1 - Page.ToolbarPlacement to Bottom in a modal doesn't work
2 - NavBar toolbar items have a different height - using in a normal NavigationPage?

Thanks

[mhrastegari]

Sure @rmarinho , the Steps to Reproduce it is just resize the sample window to the minimum size and then press the toolbar add button and you'll see the defferents.
Issue11150.zip

and yes they are two issues but they both are only on UWP and for toolbar.
should i separate them?

[EmilAlipiev]

and your test application throws another exception. when you resize to the minimum and start resizing again back to it is position it crashes. Did you see this?

[mhrastegari]

No @EmilAlipiev 🤔 just one thing weird happened for me was if app opens in minimum size at start the master page will be shown in FULL mode not partial or popover that I expect.

[PureWeen]

@mhrastegary77 does this look like a duplicate of #9042 ?

There are a few toolbar uwp height issues laying around

[mhrastegari]

Hi @PureWeen, yes I think that part is a duplicate! but what about the Platform specific part? That toolbar items placement in modal pages.

[PureWeen]

@mhrastegary77 can you remove the parts about the height on this issue? And we can make it just about the platform specific?

[mhrastegari]

Of course @PureWeen ❤️

[mhrastegari]

@EmilAlipiev it looks like you were right about that! it throws an exception in Add page(the modal page) and ONLY in debug, without debuging it's fine.