Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] BackButtonBehavior no longer displays on the first routed page in 4.7 #11244

Closed
Welchen opened this issue Jun 29, 2020 · 3 comments
Closed
Assignees
Labels
4.7.0 regression on 4.7.0 a/shell 🐚 i/regression in-progress This issue has an associated pull request that may resolve it! s/unverified New report that has yet to be verified t/bug 🐛
Projects
Milestone

Comments

@Welchen
Copy link

Welchen commented Jun 29, 2020

Description

BackButtonBehavior no longer displays a button on the initial routed to page of the application in 4.7.0.968. Reverting to 4.6.0.967 and below and it will show up.

After login our app shows the main page of the application. On this page we use the BackButtonBehavior override to add a sign out icon to return the user to back to the login page. With 4.7 our Signout button no longer is visible. The Login page and Main page are in two different ShellItems on the AppShell.xaml

Steps to Reproduce

  1. AppShell.xaml
    <ShellItem Route="Login">
        <ShellContent ContentTemplate="{DataTemplate local:LoginPage}" />
    </ShellItem>

    <ShellItem Route="Main">
        <ShellContent ContentTemplate="{DataTemplate local:MainPage}" />
    </ShellItem>
  1. LoginViewModel.cs
    await Shell.Current.GoToAsync("//Main");

  2. MainPage.xaml

    <Shell.BackButtonBehavior>
        <BackButtonBehavior Command="{Binding LogoutCommand}"
            IconOverride="{FontImage FontFamily={StaticResource FontAwesomeSolid}, 
                Glyph={x:Static utils:FontAwesomeSolid.SignOutAlt}, 
                Size=20}"/>
    </Shell.BackButtonBehavior>

Expected Behavior

Sign Out button (Icon replaces the back button icon) should show in the top left corner on the tool bar on the first and all routed to pages.

Actual Behavior

Sign Out button does not show up on the first routed to page but does show up on the rest.

Basic Information

  • Version with issue: 4.7.0.968
  • Last known good version: 4.6.0.967
  • IDE: Visual Studio 2019 Professional 16.6.2
  • Platform Target Frameworks:
    • iOS: Default (13.5)
  • Affected Devices: iPad Mini 4 (13.1.3)

Screenshots

4.6

46

4.7

47

Sample

Xamarin Project that reproduces the error

@pauldipietro pauldipietro added this to New in Triage Jun 29, 2020
@Welchen Welchen changed the title BackButtonBehavior no longer displays on the first routed page in 4.7 [Bug] BackButtonBehavior no longer displays on the first routed page in 4.7 Jun 30, 2020
@jsuarezruiz jsuarezruiz added a/shell 🐚 s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 30, 2020
@PureWeen
Copy link
Contributor

PureWeen commented Jun 30, 2020

@Welchen are you only seeing this on an iPAD?

If you don't use a FontImage but just use a local image or text does it replace?

Do you see any error messages in your application output about not being able to load the icon?

If you try to load that same FontImage into a Button does it load?

@PureWeen PureWeen moved this from New to Needs Info in Triage Jun 30, 2020
@Welchen
Copy link
Author

Welchen commented Jun 30, 2020

@PureWeen This application is only built for iPad so haven't tried any other devices.

I changed out the IconOverride for TextOverride and didn't see any text shown.

No error messages.

I tried a different FontImage into the Override and that didn't work either. We use FontImage all over the product, the Fingerprint on the right of the supplied images are FontImage and show that it is still working.

@Welchen
Copy link
Author

Welchen commented Jun 30, 2020

@PureWeen I added a link to my Issue that has a sample that I created. The sample uses text instead of icons and reproduces the issue. I also tested it against iPhone and iPad and both show the problem. Changing the Xamarin.Forms nuget package back to the newest 4.6.0 will show how it previously worked.

@samhouts samhouts moved this from Needs Info to New in Triage Jul 1, 2020
@samhouts samhouts added 4.7.0 regression on 4.7.0 i/regression labels Jul 1, 2020
@samhouts samhouts added this to the 4.7.0 milestone Jul 1, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jul 1, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jul 1, 2020
@samhouts samhouts moved this from New to Ready For Work in Triage Jul 2, 2020
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Jul 2, 2020
@samhouts samhouts added this to In Progress in Shell Jul 13, 2020
@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jul 16, 2020
Triage automation moved this from Needs Estimate to Closed Jul 20, 2020
Shell automation moved this from In Progress to Done Jul 20, 2020
@samhouts samhouts removed this from Closed in Triage Aug 19, 2020
@samhouts samhouts removed this from Done in Shell Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.7.0 regression on 4.7.0 a/shell 🐚 i/regression in-progress This issue has an associated pull request that may resolve it! s/unverified New report that has yet to be verified t/bug 🐛
Projects
No open projects
4.7.0
  
Done
Development

No branches or pull requests

4 participants