Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Label MaxLine not updating value after changing from View Model #11875

Closed
viveknegi51288 opened this issue Aug 21, 2020 · 5 comments · Fixed by #11896
Closed

[Bug] Label MaxLine not updating value after changing from View Model #11875

viveknegi51288 opened this issue Aug 21, 2020 · 5 comments · Fixed by #11896
Assignees
@jsuarezruiz
Labels
a/label e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@viveknegi51288
Copy link

viveknegi51288 commented Aug 21, 2020 •
edited

I am trying to set MaxLine property of a Label in xamarin forms, but its not reflecting properly in android but in ios its working fine.

Steps to Reproduce

  1. Create 3 labels with Maxline (with differnt binding as {Binding MaximumValue)) and 3 buttons(Binding ShowMoreLessCommand}) for each label
  2. Bind your view with View Model.
  3. Set MaximumValue = 100 on every button . click.

###It should increase the maxline of lable

It is not reflecting at all in android

Basic Information

  • Version with issue: Latest Version of Xamarin (4.8)
  • Last known good version: Never tried this
  • IDE: Visual Studio 2019
  • Platform Target Frameworks:
    • iOS: 13
    • Android: 29
    • UWP: Not using
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Can you please provide a sample app please
@viveknegi51288 viveknegi51288 added s/unverified New report that has yet to be verified t/bug 🐛 labels Aug 21, 2020
@samhouts samhouts added this to New in Triage Aug 21, 2020
@jsuarezruiz
Copy link
Contributor

Attached a reproduction sample: Issue11875.zip

Works on iOS as expected.

@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Aug 24, 2020
@jsuarezruiz jsuarezruiz removed the s/unverified New report that has yet to be verified label Aug 24, 2020
@viveknegi51288
Copy link
Author

@jsuarezruiz Its not working on android, Can you check on android as well.

@viveknegi51288
Copy link
Author

@jsuarezruiz I have check your sample app, its only working on ios, I am facing problem in android. can you please check again and let me know

@jsuarezruiz
Copy link
Contributor

Yes, is not working on Android as expected. I validated that, removed the "unverified" flag, added the "Android" flag and moved the issue to "Ready For Work".

@jsuarezruiz jsuarezruiz self-assigned this Aug 24, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Aug 24, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Aug 24, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Aug 24, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 25, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Aug 26, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 26, 2020
@samhouts samhouts removed this from Ready For Work in Triage Aug 28, 2020
@samhouts samhouts moved this from To do to In progress in Android Ready For Work Aug 28, 2020
@viveknegi51288
Copy link
Author

@samhouts any update ? when this will fix ?

Android Ready For Work automation moved this from In progress to Done Sep 7, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Sep 7, 2020
@samhouts samhouts removed this from Done in Android Ready For Work Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/label e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[Android] Fix issue updating the Label size changing the MaxLines xamarin/Xamarin.Forms
3 participants
@jsuarezruiz @samhouts @viveknegi51288