Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] FontImageSource does not work on UWP #12344

Closed
nk221 opened this issue Oct 2, 2020 · 3 comments · Fixed by #12362
Closed

[Bug] FontImageSource does not work on UWP #12344

nk221 opened this issue Oct 2, 2020 · 3 comments · Fixed by #12362
Assignees
@jsuarezruiz
Labels
4.8.0 regression on 4.8.0 a/fonticon a/fonts e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! p/UWP t/bug 🐛
Projects
vCurrent (4.8.0) UWP Ready For Work

Comments

@nk221
Copy link
Contributor

nk221 commented Oct 2, 2020

Description

FontImageSource does not work on UWP.

Steps to Reproduce

  1. Download the project from Reproduction Link
  2. Run the application - Image is displayed.
  3. Update Xamarin.Forms package to version 4.8.0.1451 or above
  4. Run the application - Image is not displayed.

Expected Behavior

The image is displayed.

Actual Behavior

The image is not displayed.

Basic Information

  • Version with issue: 4.8.0.1451
  • Last known good version: 4.8.0.1364

Reproduction Link

https://github.com/nk221/App1
@nk221 nk221 added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 2, 2020
@samhouts samhouts added this to New in Triage Oct 3, 2020
@jsuarezruiz jsuarezruiz added a/fonticon a/fonts p/UWP 4.8.0 regression on 4.8.0 e/3 🕒 3 and removed s/unverified New report that has yet to be verified labels Oct 5, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Oct 5, 2020
@jsuarezruiz
Copy link
Contributor

Is a regression. The commit that introduce the issue is: 0be2136

@jsuarezruiz jsuarezruiz self-assigned this Oct 5, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Oct 5, 2020
Merged
2 tasks
@holecekp
Copy link

holecekp commented Oct 5, 2020

I think that the mentioned commit should fix the issue #12153. It appeared in 4.8 SR 2 and the fix has not been released yet. If you are making changes to the FontImageSource on UWP, please test also that both repro projects from the issue #12153 still works (I have posted the repro projects later in the discussion to that issue).

@DennisWelu
Copy link

This is very important to get fixed for our apps in the XF 4.x series. Glad to see there's a fix in the pipeline! Hoping it is sooner rather than later.

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Nov 2, 2020
@samhouts samhouts added this to To do in UWP Ready For Work Nov 3, 2020
@samhouts samhouts removed this from Ready For Work in Triage Nov 3, 2020
@samhouts samhouts moved this from To do to In progress in UWP Ready For Work Nov 3, 2020
@rmarinho rmarinho linked a pull request Nov 6, 2020 that will close this issue
[UWP] Fixed wrong font path in FontImageSourceHandler #12362
Merged
2 tasks
UWP Ready For Work automation moved this from In progress to Done Nov 6, 2020
vCurrent (4.8.0) automation moved this from In Progress to Done Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
4.8.0 regression on 4.8.0 a/fonticon a/fonts e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! p/UWP t/bug 🐛
Projects
UWP Ready For Work
  
Done
vCurrent (4.8.0)
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UWP] Fixed wrong font path in FontImageSourceHandler xamarin/Xamarin.Forms
5 participants
@DennisWelu @jsuarezruiz @samhouts @holecekp @nk221