Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell Bottom Tabs are not visible in iOS when we route back from non tabs page to tabs page #12505

Closed
Srikanth540-L opened this issue Oct 16, 2020 · 3 comments · Fixed by #12320

Comments

@Srikanth540-L
Copy link

Srikanth540-L commented Oct 16, 2020

[Bug] Shell Bottom Tabs are not visible in iOS when we route back from on tabs page to tabs page

Description

NOTE: I would also like to bring one issue that happening in iOS when we are navigating between pages which have bottom tab and that don't , For example in the below mentioned sample click on monkey tab and select any monkey in the list and once we are monkey detail page click on monkey details we will navigate to subpage then click on go back button , you will notice that bottom tabs are invisible for the monkey detail page even though TabBarIsVisible is set ti true , This happens one when you Shell.Current.Navigation.PopAsync(false) for Shell.Current.Navigation.PopAsync(true) the tabs are visible after some delay.

Steps to Reproduce

  1. Xamarin_Forms___Xaminals.zip
  2. Download the above sample
  3. Click on Monkey tab and then click any monkey in the list then we will route to Monkey details
    4 Once on the Monkey Detail Click on the page then we will navigate to Subpage there click on Go Back
    5 You will be back on Monkey Detail page with out tabs even though TabBarIsVisible is set to true

Expected Behavior

Should show tabs if TabBarIsVisible is set to true

Actual Behavior

Bottom tabs are not visible

Basic Information

  • Version with issue: Xamarin forms 4.8 Latest
  • Affected Devices: iOS devices

Screenshots

Screenshot 2020-10-16 at 1 06 44 PM

Screenshot 2020-10-16 at 1 07 04 PM

Screenshot 2020-10-16 at 1 07 20 PM

Screenshot 2020-10-16 at 1 07 35 PM

Reproduction Link

Xamarin_Forms___Xaminals.zip

@Srikanth540-L Srikanth540-L added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 16, 2020
@samhouts samhouts added this to New in Triage Oct 16, 2020
@Srikanth540-L Srikanth540-L changed the title [Bug] Shell Bottom Tabs are not visible in iOS when we route back from on tabs page to tabs page [Bug] Shell Bottom Tabs are not visible in iOS when we route back from non tabs page to tabs page Oct 16, 2020
@rachelkang
Copy link
Contributor

Hi, @Srikanth540-L - thank you so much for submitting this issue! We'll work to fix this :)

In the meantime, a temporary workaround would be to reenable the popasync animation. So in your SubPage code-behind, if you remove the bool so that you have await Shell.Current.Navigation.PopAsync(); instead of await Shell.Current.Navigation.PopAsync(false);, you should see the Bottom Tabs again. Hope this will work well for the time being!

@rachelkang rachelkang added this to Backlog in Shell via automation Oct 16, 2020
@rachelkang rachelkang moved this from New to Ready For Work in Triage Oct 16, 2020
@rachelkang rachelkang added a/shell 🐚 a/tabbedpage e/1 🕐 1 and removed s/unverified New report that has yet to be verified labels Oct 16, 2020
@PureWeen
Copy link
Contributor

This should be fix by the following PR

#12320

Triage automation moved this from Ready For Work to Closed Oct 18, 2020
Shell automation moved this from Backlog to Done Oct 18, 2020
@Srikanth540-L
Copy link
Author

Srikanth540-L commented Oct 20, 2020

Hi @rachelkang , await Shell.Current.Navigation.PopAsync(); will solve the issue but there is delay when the tabs are visible but same is not happening when you use the back button in navigation bar which is inbuilt in the xamarin forms.
@PureWeen when this fix will be available in the xamarin forms updated version and has the fix been validated in the above sample before closing the issue ?

@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts moved this from In Progress to Done in vNext+1 (5.0.0) Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Shell
  
Done
Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

3 participants