You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 1, 2024. It is now read-only.
A Button on iOS seems to ignore vertical padding set to 0.
Steps to Reproduce
Create a Button, set a 0 vertical padding
Expected Behavior
0 vertical padding
Actual Behavior
The button height is 44 points.
Because the ButtonRenderer sets a minimumHeight to 44f.
From Xamarin.Forms.Platform.iOS.ButtonRenderer:
// This looks like it should be a const under iOS Classic,
// but that doesn't work under iOS
// ReSharper disable once BuiltInTypeReferenceStyle
// Under iOS Classic Resharper wants to suggest this use the built-in type ref
// but under iOS that suggestion won't work
readonly nfloat _minimumButtonHeight = 44; // Apple docs
nfloat IButtonLayoutRenderer.MinimumHeight => _minimumButtonHeight;
Basic Information
Version with issue: 4.8.0.1560
Last known good version: none
IDE: Rider
Platform Target Frameworks:
iOS 13:
Nuget Packages: Xamarin.Forms
Affected Devices: all
Workaround
None, as methods that could be overriden are all internals.
The text was updated successfully, but these errors were encountered:
rmarinho
changed the title
[Bug] Remove _minimumButtonHeight in ButtonRenderer
[Enhancement] Allow to override _minimumButtonHeight in ButtonRenderer
Nov 3, 2020
Description
A Button on iOS seems to ignore vertical padding set to 0.
Steps to Reproduce
Expected Behavior
0 vertical padding
Actual Behavior
The button height is 44 points.
Because the ButtonRenderer sets a minimumHeight to 44f.
From Xamarin.Forms.Platform.iOS.ButtonRenderer:
Basic Information
Workaround
None, as methods that could be overriden are all internals.
The text was updated successfully, but these errors were encountered: