Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] [Shell] [iOS] [Android] Shell Navigation (via RegisterRoute) behaves differently in 5.0 #13611

Closed
dmariogatto opened this issue Feb 1, 2021 · 0 comments · Fixed by #13648

Comments

@dmariogatto
Copy link
Contributor

Description

Registered routes behave differently when using Shell.GoToAsync (XF 5.0 and up).

Steps to Reproduce

  1. Create a Shell and three content pages
  2. Set the content of the shell to one of the pages
  3. Manually register routes for the last to pages

The navigation routes will look like the below,

  • "page1"
  • "page1/page2"
  • "page1/page2/page3"

Without data,

Page1 calls: Shell.GoToAsync("page1/page2"), shows Page2 ✔
Page2 calls: Shell.GoToAsync("page1/page2/page3"), shows Page3 ✔

Page3 back button (from Shell navigation bar): fails on Android ❌ (Shell: Failed to Navigate Back: System.ArgumentException: unable to figure out route for: //D_FAULT_TabBar4/page1/D_FAULT_ShellContent3/page1/page2), works on iOS ✔

With data,

Page1 calls: Shell.GoToAsync("page1/page2?data=1"), fails on Android/iOS❌Relative routing to shell elements is currently not supported. Try prefixing your uri with ///: ///page1/page2?data=1

Page2 calls: Shell.GoToAsync("page1/page2/page3?data=1"), fails on Android/iOS❌Relative routing to shell elements is currently not supported. Try prefixing your uri with ///: ///page1/page2/page3?data=1

Expected Behavior

Shell routing behaviour should work the same as 4.8

Actual Behavior

Shell routing behaviour is different in 5.0

Basic Information

  • Version with issue: 5.0 and up
  • Last known good version: 4.8 and down

Reproduction Link

BrokenShellRoutes.zip

@dmariogatto dmariogatto added s/unverified New report that has yet to be verified t/bug 🐛 labels Feb 1, 2021
@samhouts samhouts added this to New in Triage Feb 1, 2021
@PureWeen PureWeen added this to To Fix in 5.0.0 SR 3 via automation Feb 3, 2021
@PureWeen PureWeen self-assigned this Feb 3, 2021
@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Feb 3, 2021
@rachelkang rachelkang moved this from New to Ready For Work in Triage Feb 3, 2021
@PureWeen PureWeen moved this from To Fix to Issue In Progress in 5.0.0 SR 3 Feb 4, 2021
Triage automation moved this from Ready For Work to Closed Feb 9, 2021
5.0.0 SR 3 automation moved this from Issue In Progress to Done Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

3 participants