Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Android ObjectDisposedException thrown Button inside CollectionView with Binding #14757

Closed
muhamadsalibi opened this issue Oct 19, 2021 · 5 comments · Fixed by #14760
Closed

[Bug] Android ObjectDisposedException thrown Button inside CollectionView with Binding #14757

muhamadsalibi opened this issue Oct 19, 2021 · 5 comments · Fixed by #14760
Labels
a/button a/collectionview p/Android s/unverified New report that has yet to be verified t/bug 🐛
Projects
Triage 5.0.0 SR7 (Planning) - Target Date No...

Comments

@muhamadsalibi
Copy link

muhamadsalibi commented Oct 19, 2021 •
edited
Loading

Description

This has been a reoccurring problem on multiple projects I am working on. I've been able to narrow it down to the case when I am using a Button inside a CollectionView with Binding. When the Button is disposed, changing the bindable property will throw an ObjectDisposedException.

The exception is not thrown when the Button is replaced with a Label or Entry with the same binding.

The exception still occurs with Forms.SetFlags("UseLegacyRenderers") added or not.

Steps to Reproduce

Repository with example project with the issue:

https://github.com/muhamadsalibi/Issue14757

  1. In the example code click "To test page"
  2. navigate back to main page
  3. Repeat steps (1 & 2) until Garbage collection occurs
  4. Click "Change Text"

Or create a blank project and:

  1. Create a string bindable property
  2. Navigate to a page with Button inside a CollectionView with binding to the string bindable property
  3. Navigate away from the page with the Button
  4. Repeat steps 2 & 3 until a Garbage collection occurs
  5. Change the bindable property
  6. Exception is thrown

Expected Behavior

No exception is thrown

Actual Behavior

ObjectDisposedException is thrown

Basic Information

  • Version with issue: 5.0.0.2196
  • Last known good version: -
  • Platform Target Frameworks:
    • Android: 11.0
  • Android Support Library / AndroidX Version:
  • NuGet Packages:
  • Affected Devices:

Environment

Show/Hide Visual Studio info 
Microsoft Visual Studio Community 2019
Version 16.10.3
VisualStudio.16.Release/16.10.3+31424.327
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Community

Visual C++ 2019   00435-60000-00000-AA482
Microsoft Visual C++ 2019

ASP.NET and Web Tools 2019   16.10.526.50910
ASP.NET and Web Tools 2019

ASP.NET Web Frameworks and Tools 2019   16.10.526.50910
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0   16.10.526.50910
Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools   16.10.526.50910
Azure Functions and Web Jobs Tools

C# Tools   3.10.0-4.21318.11+7ceb633154acb9d716fd3eb2b6df1a0468d8e416
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Cookiecutter   16.10.21111.19
Provides tools for finding, instantiating and customizing templates in cookiecutter format.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

GitHub.VisualStudio   2.11.106.19330
A Visual Studio Extension that brings the GitHub Flow into Visual Studio.

IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info

Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.40423.1

Microsoft Continuous Delivery Tools for Visual Studio   0.4
Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager   2.1.113+g422d40002e.RR
Install client-side libraries easily to any web project

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers   1.2
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio   16.10.15 (552afdf)
Support for debugging Mono processes with Visual Studio.

NuGet Package Manager   5.10.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

Python   16.10.21111.19
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.

Python - Conda support   16.10.21111.19
Conda support for Python projects.

Python - Django support   16.10.21111.19
Provides templates and integration for the Django web framework.

Python - Profiling support   16.10.21111.19
Profiling support for Python projects.

Razor (ASP.NET Core)   16.1.0.2122504+13c05c96ea6bdbe550bd88b0bf6cdddf8cde1725
Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools   16.0.62106.24090
Microsoft SQL Server Data Tools

Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.

TypeScript Tools   16.0.30429.2002
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   3.10.0-4.21318.11+7ceb633154acb9d716fd3eb2b6df1a0468d8e416
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   16.10.0-beta.21262.7+1b23bbeda88ea3cb9be9af777f4c99fa8663df81
Microsoft Visual F# Tools

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Container Tools Extensions   1.0
View, manage, and diagnose containers within Visual Studio.

Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake

Visual Studio Tools for Containers   1.0
Visual Studio Tools for Containers

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Foo   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

Xamarin   16.10.000.234 (d16-10@ecaf29b)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   16.10.0.115 (remotes/origin/c750fbf1bde3c720d077f51640fe197c6dac7cbe@c750fbf1b)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   16.10.5 (355b57a)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   11.3.0.4 (d16-10/ae14caf)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: b4a3858
    Java.Interop: xamarin/java.interop/d16-10@f39db25
    ProGuard: Guardsquare/proguard/v7.0.1@912d149
    SQLite: xamarin/sqlite/3.35.4@85460d3
    Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-10@c5732a0


Xamarin.iOS and Xamarin.Mac SDK   14.20.0.24 (c4b89cddb)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

Build Logs

Screenshots

Reproduction Link

https://github.com/muhamadsalibi/Issue14757

Workaround
@muhamadsalibi muhamadsalibi added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 19, 2021
@jfversluis
Copy link
Member

Hey there, thanks for reporting this and the great details and repro! Have you tried it on iOS? It doesn't happen there? And just to be clear, this happened before version 2196 as well, right?

@muhamadsalibi
Copy link
Author

@jfversluis I cannot reproduce on iOS, it seems an Android only issue. This happened indeed before 2196, at least in 2012 as well.

@jsuarezruiz jsuarezruiz added this to New in Triage via automation Oct 19, 2021
@jfversluis jfversluis mentioned this issue Oct 19, 2021
Merged
2 tasks
@jfversluis
Copy link
Member

Hey @muhamadsalibi, a PR (#14760) for this is open now, would you be able to grab the NuGet as described here, when the build is complete and let us know if this fixes this issue? That will greatly speed up the review process.

Besides verifying if this particular issue is fixed also be sure to check other scenarios in the same area to make sure that this fix doesn't accidentally has side-effects 🙂

Thanks!

@jfversluis jfversluis moved this from To Fix to PR Needs Review in 5.0.0 SR7 (Planning) - Target Date Nov. 10th Oct 19, 2021
@muhamadsalibi
Copy link
Author

This indeed fixes the issue for the project I'm working on with a similar setup. Thanks! 👍

I will be testing other scenarios in the coming couple of days.

@jfversluis
Copy link
Member

Thanks! I will merge this one, let me know if you run into something while testing this more :)

Triage automation moved this from New to Closed Oct 20, 2021
5.0.0 SR7 (Planning) - Target Date Nov. 10th automation moved this from PR Needs Review to Done Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/button a/collectionview p/Android s/unverified New report that has yet to be verified t/bug 🐛
Projects
Triage
  
Closed
5.0.0 SR7 (Planning) - Target Date No...
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check if View is not disposed to prevent NRE for Android Button xamarin/Xamarin.Forms
2 participants
@jfversluis @muhamadsalibi