[Enhancement] Left-aligned ToolbarItems on Android & iOS

[samhouts]

Rationale

ToolbarItems currently display aligned to the right on all platforms. There is no way to display a ToolbarItem on the left. This is useful for many designs, including completely customizing the back button on a NavigationPage.

Implementation

Add new platform specific properties to ToolbarItem:

public enum ToolbarItemPosition { Start, End }

ToolbarItem.On<Android>().ToolbarItemPosition = ToolbarItemPosition.Start;
ToolbarItem.On<iOS>().ToolbarItemPosition = ToolbarItemPosition.Start;

Renderers will need to be updated accordingly.

Expected Result

Android

• ToolbarItemPosition will default to End.
• If the ToolbarItemPosition is set to Start, ToolbarItem will be displayed on the left side of the screen when in LTR mode and on the right side of the screen when in RTL mode.

iOS

See Android

UWP

No change. This is not a supported paradigm for UWP, so it will not be affected.

Implications for CSS

None

Backward Compatibility

Since we are adding new properties, there should be no compatibility problems as long as:

1. We ensure that a ToolbarItem's Position defaults to the right side of the screen, as is the expected behavior now.
2. We ensure that any Effects or Custom Renderers that may have been created to produce this behavior take precedence over any values that we set, to the best of our ability.

Third party renderers will need to be updated to ensure that this functionality is officially supported.

Difficulty : Easy

See https://forums.xamarin.com/discussion/85097/left-toolbaritems-in-xamarin-forms for original proposal.

[ghost]

Hi, i would like to see if i can deal with this issue

[dhaligas]

@samhouts will this allow both left and right toolbar items? we need the ability to have both.

below is exactly what forms needs to allow

[samhouts]

@dhaligas Yes, that's the idea.

[jassmith]

@netapau you still working on this?

[ghost]

@jassmith
I think someone a little more experienced should take it.
I was able to advance to the creation of the enumeration and modification of ToolbarItem
Here are my questions:

• Do you have to make new renderers?
• Do we have to work at Page.cs?

For the first time I look in this code I can not advance anymore.

[jassmith]

The answers are no and no to both, though the second would be ideally a yes for an optimal implementation. I have moved this back to the available for implementation column

[dhaligas]

@jassmith i need this .. do I have to modify the NavigationPageRenderer (Android) to make this work?

[jassmith]

@dhaligas the implementation of this for iOS is straightforward and similar on Android

1. Implement the PlatformSpecific API as shown in the spec.

2. Go to

   Xamarin.Forms/Xamarin.Forms.Platform.iOS/Renderers/NavigationRenderer.cs

   Line 1008 in 6668ff6

   foreach (var item in _tracker.ToolbarItems)

   and modify such that there are now 3 lists. The primaries list needs to be split into two lists based on the whether it is "start" or "end". The "end" list goes into where it goes normally:

NavigationItem.SetRightBarButtonItems(primaries == null ? new UIBarButtonItem[0] : primaries.ToArray(), false);

and the start list would basically be a duplicate of that line of code, but instead calling SetLeftBarButtonItems

This is such an easy issue it will surely be picked up by the team or myself very soon now that its in the F100 list which gives us approval to do it.

[dhaligas]

@jassmith the iOS one seems simple and I am able to do it without modifying the core. But android seems like you have to get into the internals of NavigationPageRenderer to support this

[jfversluis]

For Android it's basically the same as @jassmith describes, but then here I guess?

Xamarin.Forms/Xamarin.Forms.Platform.Android/Platform.cs

Line 383 in c18e85e

foreach (ToolbarItem item in _toolbarTracker.ToolbarItems)

edit: I have taken a quick look at it, but I can't see any way to achieve this on Android? Besides building a custom toolbar, but I figure that will open up some kind of Pandora's box with current (backwards) compatibility

[dhaligas]

@jfversluis on android there is the Toolbar.NavigationIcon that can be used to set the Left Toolbar Item but that is buried in the NavigationPageRenderer. This only allows one item which is fine for left Left Toolbar Items the majority of the time

[jfversluis]

@dhaligas I didn't really look into it, but NavigationIcon sounds like it can hold just one?

[jassmith]

Upon further review I was too hasty with my statements about Android. The API will need to be modified to only allow one icon for Android and to make it clear its an override for the back button.

[dhaligas]

@jassmith I have to do this now. is there a way to hack this in on Android with a renderer or effect?

[smartprogrammer93]

If there is a custom renderer we can write to do this, it would be optimal. i am in desperate need for it.

[pnda489]

Is it possible to add options to set the Toolbaricon?

Left, Middle, Right ? It would be more easy to set an image icon of a company in the center of the Navbar or align it to the left Controlbutton (Back or Hamburger)

[Shaboo]

their is a custom renderer for ContentPage in order to move toolbar items to the left [iOS only],
so, If using the same logic for TabbedRenderer in order to move toolbar items to left when using tabbedpage, the following behavior happened:

when the app first lunch, every thing is fine, but when navigate to other tab, the items on left duplicate on the right,

and till now I can't fix this issue, and I think the problem in these lines

Xamarin.Forms/Xamarin.Forms.Platform.iOS/Renderers/TabbedRenderer.cs

Lines 172 to 176 in 8ed7a28

	void OnPagePropertyChanged(object sender, PropertyChangedEventArgs e)
	{
	// Setting TabBarItem.Title in iOS 10 causes rendering bugs
	// Work around this by creating a new UITabBarItem on each change
	if (e.PropertyName == Page.TitleProperty.PropertyName && !Forms.IsiOS10OrNewer)

I don't know exactly but please keep this in mind when implementing this feature

[jassmith]

Learnings from the shell branch are that this will 100% not work as specced. We need to take the API back to the drawing board here and make sure it reflects the actual capabilities of the platforms.

[KennyDizi]

any update for this enhancement?

[Osmosis311]

Would love it if this can be made to happen, or at least if anyone has the CustomRenderer code for Android. I've got pages where I need Save and Cancel buttons, and if the user, clicks Cancel, I need to show a confirmation that they really want to leave and lose unsaved data...

[Shaboo]

@Osmosis311 did you try TitleView?

[KennyDizi]

@Osmosis311 did you try TitleView?

they are difference things @Shaboo

[minaairsupport]

yea I think these different things, toolbar position is very important to release it as soon as possible

[smartprogrammer93]

Any Idea if this will be implemented?

[LuoyeAn]

Any luck?

[decv86]

Pls implementation!

[decv86]

Pls implementation!

[YZahringer]

I think UWP should also be supported: https://www.rudyhuyn.com/blog/2015/12/23/display-an-appbarbutton-on-the-left-side-of-a-commandbar/

[winterdouglas]

I'm just in the need of it again :( Any updates on this one?

[jfversluis]

Sorry to hear that @winterdouglas! I'm afraid not.

Although the initial spec still states this as easy, I don't think it is. From what I remember looking into it, iOS for example only allows 1 button on the left. And from Jasons comments it looks like it's not that easy on Android as well. Maybe the APIs changed meanwhile, that would be awesome, I'm happy to be proven wrong in this case :)

That would mean, in order to achieve this, we would have to create a fully customized Navigation bar/page ourselves which is a huge investment to get right. One alternative could be to use the TitleView as suggested. Or if you have any other suggestions to make this happen, I'm all ears.

[dionisoliveira]

it's works for me

[assembly: ExportRenderer(typeof(CustomBackButtonPage), typeof(CustomContentPageRenderer))]
namespace SMC.BackButton.iOS.Renderer
public class CustomContentPageRenderer : PageRenderer
{
public static bool pushPage = false;
public static bool closePage = false;

    public override void ViewWillAppear(bool animated)
    {
        base.ViewWillAppear(animated);
        try
        {
       
            
            var root = this.NavigationController.TopViewController;
       
            var icon = UIImage.FromBundle("ico_freq_off.png");
          
            root.NavigationItem.SetLeftBarButtonItem(new UIBarButtonItem(icon, UIBarButtonItemStyle.Plain, (sender, args) =>
            {
                MessagingCenter.Send<object>(this, "ClosePAge");
            }), false);

           
           
        }
        catch (Exception e)
        {
            closePage = false;
            pushPage = false;
        }
    }

  


}

[jfversluis]

Hey everyone, thanks for all the input and effort here. This won't be able to make it into Xamarin.Forms anymore unfortunately. If it's something you're still interested in, make sure to see if it's on the roadmap for .NET MAUI or open an issue with a feature request and add all the details.

Thanks!

[mackayn]

@jfversluis Given up on the native toolbar renderer completely. It's only useful for basic scenarios. On the last 4 commercials apps I've been involved with, we rolled out own toolbar as it was the way we could realize the designs. Allowing drawing like Flutter is the way to go.

[jfversluis]

Thanks @mackayn! That seems definitely be the thing holding us back here and something we're keeping in mind.