Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell] Page content on iOS is cut off #4342

Closed
jimmgarrido opened this issue Nov 7, 2018 · 3 comments
Closed

[Shell] Page content on iOS is cut off #4342

jimmgarrido opened this issue Nov 7, 2018 · 3 comments
Assignees
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/4 🕓 4 t/bug 🐛
Milestone

Comments

@jimmgarrido
Copy link
Contributor

jimmgarrido commented Nov 7, 2018

Description

I am seeing the top of the page being cut off when using shell on iOS. So far I've noticed this happens to controls when inside a StackLayout, but a Label used by itself also has this issue so they may be more instances of this.

Steps to Reproduce

  1. Create a new project using shell
  2. Add a StackLayout to a page with another control like ListView inside it
  3. Deploy to iOS

Expected Behavior

The entire control is visible

Actual Behavior

The top of the control is cutoff by the edge of the screen, navbar, etc.

Basic Information

  • Version with issue: 3.5.0.988554
  • Last known good version:
  • IDE: VS2017 15.9
  • Platform Target Frameworks:
    • iOS: 12.1
  • Affected Devices:

Screenshots

image

Reproduction Link

App80.zip
Parent: #2415

@pauldipietro pauldipietro added this to New in Triage Nov 7, 2018
@rmarinho rmarinho moved this from New to Ready For Work in Triage Nov 8, 2018
@samhouts samhouts added this to To do in Sprint 145 Nov 26, 2018
@samhouts samhouts added this to the 3.5.0 milestone Dec 4, 2018
@samhouts samhouts added this to Ready in v3.5.0 Dec 4, 2018
@samhouts samhouts added the e/4 🕓 4 label Dec 14, 2018
@samhouts samhouts added this to To do in Other Ready For Work Dec 14, 2018
@samhouts samhouts removed this from Ready For Work in Triage Dec 14, 2018
@samhouts samhouts added this to To do in Sprint 146 Dec 15, 2018
@samhouts samhouts moved this from To do to Returned to backlog in Sprint 146 Jan 9, 2019
@samhouts samhouts modified the milestones: 3.5.0, 4.0.0 Jan 10, 2019
@samhouts samhouts removed this from Ready in v3.5.0 Jan 11, 2019
@tmulin
Copy link

tmulin commented Jan 25, 2019

I try to use a ScrollView wrap the StackLayout , in this case the page displays OK !

@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Feb 14, 2019
@davidortinau
Copy link
Contributor

As @tmulin points out, ScrollView is ok. I can also get this to be ok without a ScrollView by enabling UseSafeArea on the ContentPage.

shell-ios-scrollview

This also shows oddly in the Previewer, down by about 20px.

shell-scrollview-previewer

The same content of a Grid without a ScrollView is under the NavigationBar:

shell-ios-vertical

@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Feb 19, 2019
@samhouts samhouts added this to To do in Sprint 149 via automation Feb 19, 2019
@samhouts samhouts added this to To do in v3.6.0 Feb 19, 2019
@samhouts samhouts modified the milestones: 3.6.0, 4.0.0 Feb 21, 2019
@samhouts samhouts removed this from To do in v3.6.0 Feb 21, 2019
@samhouts samhouts moved this from To do to In progress in Sprint 149 Feb 28, 2019
@samhouts samhouts added this to To do in v4.0.0 Mar 2, 2019
@rmarinho
Copy link
Member

rmarinho commented Mar 6, 2019

Just set Shell.SetPaddingInsets="true" in your ShellItem.

@rmarinho rmarinho closed this as completed Mar 6, 2019
Other Ready For Work automation moved this from To do to Done Mar 6, 2019
Sprint 149 automation moved this from In progress to Done Mar 6, 2019
@samhouts samhouts moved this from To do to Done in v4.0.0 Mar 13, 2019
@samhouts samhouts removed this from Done in Other Ready For Work May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/4 🕓 4 t/bug 🐛
Projects
No open projects
Sprint 145
  
To do
Sprint 146
  
Returned to backlog
Sprint 149
  
Done
v4.0.0
  
Done
Development

No branches or pull requests

6 participants