[Bug] ToolbarItem Order property ignored

[Darlingtone]

Description

Then Order property of ToolbarItem is totally ignored, the item is always displayed as primary even when set to secondary

Steps to Reproduce

1. Create a new XF project using the Shell template
2. On a ContentPage add ToolbarItem and set Order to secondary
3. Run on Android device

Expected Behavior

Items with order set to primary show on navigation bar while items with order set to secondary shows as a pop up menu when the 3-dots icon is tapped

Actual Behavior

All ToolbarItem show up on the Navigation bar regardless of their order settings, the 3-dots icon don't even show

Basic Information

• Version with issue: Xamarin.Forms 4.0.0.394984-pre10
• IDE: Visual Studio Community 2019

[kingces95]

Would you mind attaching a zipped reproduction?

[Darlingtone]

Here is a GitHub repo XamToolbarDemo

This is a just the default VS 2019 Xamarin.Forms App template I only added more Toolbar items and set their Order property to Secondary

Tested on actual device Tecno F1 Android 8.1.0

[marcellangmaier]

Experienced the same behaviour.

[anotherlab]

I'm experiencing the same behavior on Android & iOS.

VS 2019
XF 4.0.0.482894

[marcellangmaier]

same with
XF 4.1.0.496342-pre2

[eramrit78]

same issue i have.
in XF 4.1

[Munde]

Experiencing the same

[edupxavier]

Same with XF 4.2.0.709249

[eramrit78]

Issue come when used shell.

[mfeingol]

Same issue here with 4.2.0.778463. This is blocking my intended migration from Master-Detail to Shell.

@samhouts: I don't suppose there are any workarounds for this?

[samhouts]

I'm afraid I'm not aware of any workarounds at this time. @PureWeen ?

[jfversluis]

The error originates here. The Order simply is not taken into account.

I've opened a PR to fix that

[mfeingol]

@jfversluis: greatly appreciated!

One question, while you're in the area: I probably should have filed an issue for this, but when I was evaluating porting over to Shell, I noticed that ToolbarItems from sub-pages inside a TabbedPage weren't being picked up by the Shell at all. Is that by design, or does it also need to be fixed?

(I can provide a repro if needed.)

[jfversluis]

@iooovolts @Darlingtone I think the fix in my PR has just missed the release that just came out. Please be on a lookout for the next 4.2 or 4.3-pre release which should include it for sure.

[KoenMat]

Since 4.3.0.908675 it is fixed for Android, but not for IOS.
ToolbarItems always appear as primary even if configered as secondary.

[jfversluis]

@KoenMat it seems you are totally right. Since this was focussed on Android I didn't pay any attention to iOS. I've opened a new issue for it to track it properly.