Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell TabBarIsVisible Ignored #6485

Closed
seansparkman opened this issue Jun 11, 2019 · 1 comment · Fixed by #12320
Closed

[Bug] Shell TabBarIsVisible Ignored #6485

seansparkman opened this issue Jun 11, 2019 · 1 comment · Fixed by #12320
Labels
a/shell 🐚 e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
Other Ready For Work Shell vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@seansparkman
Copy link

seansparkman commented Jun 11, 2019 •
edited
Loading

Description

The TabBar should not be visible on "On Boarding" screen.

Steps to Reproduce

  1. Create a new on boarding ContentPage
  2. Set the Shell.TabBarIsVisible to False
  3. Set the Shell.NavBarIsVisible to False
  4. Register the new ContentPage as a Route with Routing.RegisterRoute in the constructor of the AppShell.xaml.cs
  5. Call GoToAsync in the constructor

Expected Behavior

The TabBar and the NavBar should not be visible.

Actual Behavior

NavBar does not show up but the TabBar does. Navigating to subsequent pages seem to work just fine.

Basic Information

  • Version with issue: 4.0.0.482894
  • Last known good version: N/A
  • IDE: Visual Studio 2019 for Windows 16.1.2
  • Platform Target Frameworks:
    • iOS: 12.10.0.153
    • Android: N/A
    • UWP: N/A
  • Android Support Library Version: N/A
  • Nuget Packages: Just what comes with the template
  • Affected Devices:

Screenshots

Screenshot with tabbar showing

Reproduction Link

https://github.com/seansparkman/ShellNavigationExample
https://github.com/seansparkman/ShellNavigationExample/blob/master/ShellNavigationRegistration/ShellNavigationRegistration/Views/OnBoarding.xaml#L8-L9
@seansparkman seansparkman added s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 11, 2019
@pauldipietro pauldipietro added this to New in Triage Jun 11, 2019
@jfversluis jfversluis added a/shell 🐚 and removed s/unverified New report that has yet to be verified labels Jun 11, 2019
@jfversluis jfversluis mentioned this issue Jun 12, 2019
Closed
@rmarinho rmarinho added the e/3 🕒 3 label Jun 18, 2019
@rmarinho rmarinho moved this from New to Ready For Work in Triage Jun 18, 2019
@samhouts samhouts added this to To do in Other Ready For Work Jun 18, 2019
@samhouts samhouts removed this from Ready For Work in Triage Jun 18, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Dec 8, 2019
@samhouts samhouts added this to Backlog in Shell Jan 3, 2020
@MarcoParreira
Copy link

This still happens on iOS

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Feb 24, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Sep 18, 2020
@PureWeen PureWeen mentioned this issue Oct 1, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 1, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Oct 1, 2020
Other Ready For Work automation moved this from To do to Done Oct 20, 2020
Shell automation moved this from Backlog to Done Oct 20, 2020
vCurrent (4.8.0) automation moved this from In Progress to Done Oct 20, 2020
vNext+1 (5.0.0) automation moved this from To do to Done Oct 20, 2020
@samhouts samhouts removed this from Done in vCurrent (4.8.0) Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/shell 🐚 e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
Other Ready For Work
  
Done
Shell
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Trigger pop logic when you replace back button with icon xamarin/Xamarin.Forms
5 participants
@jfversluis @seansparkman @rmarinho @samhouts @MarcoParreira