Forms 4.1: Device.GetNamedSize throws exception on Android

[davidbritch]

Description

In Forms 4.1-pre1, calling Device.GetNamedSize on Android fails (ArgumentOutOfRangeException) for the following NamedSizes: Body, Header, Title, Subtitle, Caption.

            var size1 = Device.GetNamedSize(NamedSize.Default, typeof(Label));
            var size2 = Device.GetNamedSize(NamedSize.Micro, typeof(Label));
            var size3 = Device.GetNamedSize(NamedSize.Small, typeof(Label));
            var size4 = Device.GetNamedSize(NamedSize.Medium, typeof(Label));
            var size5 = Device.GetNamedSize(NamedSize.Large, typeof(Label));
            var size6 = Device.GetNamedSize(NamedSize.Body, typeof(Label));
            var size7 = Device.GetNamedSize(NamedSize.Header, typeof(Label));
            var size8 = Device.GetNamedSize(NamedSize.Title, typeof(Label));
            var size9 = Device.GetNamedSize(NamedSize.Subtitle, typeof(Label));
            var size10 = Device.GetNamedSize(NamedSize.Caption, typeof(Label));

Steps to Reproduce

1. On Android, call Device.GetNamedSize for Body, Header, Title, Subtitle, and Caption.

Expected Behavior

double values are returned.

Actual Behavior

An ArgumentOutOfRangeException is thrown.

Basic Information

• Version with issue: 4.1.0.483098
• IDE: VS for Mac 8.0.9
• Platform Target Frameworks:
  • Android: 9.0
• Android Support Library Version: Transitive restore from the Forms NuGet

[davidbritch]

Looks like #5985 didn't do all the required modifications for Android (https://github.com/xamarin/Xamarin.Forms/blob/4.1.0/Xamarin.Forms.Platform.Android/Forms.cs#L629).

[StephaneDelcroix]

/cc @Clancey