Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell: Setting Shell.BackgroundColor overrides all colors of TabBar #7396

Closed
KoenMat opened this issue Sep 5, 2019 · 1 comment · Fixed by #7962
Closed

[Bug] Shell: Setting Shell.BackgroundColor overrides all colors of TabBar #7396

KoenMat opened this issue Sep 5, 2019 · 1 comment · Fixed by #7962
Labels
a/shell 🐚 e/1 🕐 1 hacktoberfest 🍻 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects

Comments

@KoenMat
Copy link

KoenMat commented Sep 5, 2019

Description

If you specify Shell.BackgroundColor (e.g. Green) without also specifying the TabBar-colors, all TabBar-colors are also green, so all you see is a green TabBar, no icons. If you also specify all Shell.TabBarXxxColors, then it works as expected. In the 'Xanimals'-sample app, this is done rightly with a style. If this isn't a bug, it should be better documented.
This is no problem if you don't specify a Shell.BackgroundColor.
Only tested on Android device.

Steps to Reproduce

  1. Take the 'Xanimals'-sample.
  2. Remove the references to the styles in every ShellContent-section
  3. Put BackgroundColor="Green" in '<Shell' header
  4. Run and notice that the bottom TabBar is green and no icons are visible because they are also green.

Expected Behavior

The colors should behave independently

Actual Behavior

TabBar colors all have the same color as set by Shell.BackgroundColor, so no icons visible.

Basic Information

  • Version with issue: 4.2.0.709249
  • Last known good version: ?
  • IDE: Visual Studio 2019
  • Android: 8.1.0
@KoenMat KoenMat added s/unverified New report that has yet to be verified t/bug 🐛 labels Sep 5, 2019
@pauldipietro pauldipietro added this to New in Triage Sep 5, 2019
@PureWeen PureWeen added e/1 🕐 1 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed s/unverified New report that has yet to be verified labels Oct 4, 2019
@PureWeen PureWeen moved this from New to Ready For Work in Triage Oct 4, 2019
@samhouts samhouts removed this from Ready For Work in Triage Oct 4, 2019
@felipebaltazar
Copy link
Contributor

felipebaltazar commented Oct 11, 2019

Hello!
Can i work on this issue?

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 12, 2019
@samhouts samhouts added this to In Progress in v4.3.0 Oct 12, 2019
@samhouts samhouts added this to In Progress in v4.4.0 Oct 18, 2019
@samhouts samhouts removed this from In Progress in v4.3.0 Oct 18, 2019
Android Ready For Work automation moved this from To do to Done Oct 25, 2019
v4.4.0 automation moved this from In Progress to Done Oct 25, 2019
@samhouts samhouts removed this from Done in Android Ready For Work May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 e/1 🕐 1 hacktoberfest 🍻 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
No open projects
v4.4.0
  
Done
4 participants