Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Performance issue with ItemSizingStrategy on CollectionView #8314

Open
Clancey opened this issue Oct 30, 2019 · 3 comments
Open

[Bug] Performance issue with ItemSizingStrategy on CollectionView #8314

Clancey opened this issue Oct 30, 2019 · 3 comments
Labels
a/collectionview a/performance help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@Clancey
Copy link
Contributor

Clancey commented Oct 30, 2019

Collection view does not add a default ItemSizingStrategy which defaults to MeasureAll.

This causes a major performance hit when using the GridLayout. With 100 items it adds a good 5 seconds to loading. It should default to MeasureFirstItem

Steps to Reproduce

Expected Behavior

Actual Behavior

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE:
  • Platform Target Frameworks:
    • iOS:
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Screenshots

Reproduction Link

@Clancey Clancey added t/bug 🐛 s/unverified New report that has yet to be verified labels Oct 30, 2019
@pauldipietro pauldipietro added this to New in Triage Oct 30, 2019
@jsuarezruiz jsuarezruiz changed the title [Bug] [Bug] Performance issue with ItemSizingStrategy on CollectionView Oct 31, 2019
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Oct 31, 2019

James, Could you share a repro sample or more info (layout used in the DataTemplate, etc) ?. I have been doing tests #8325 and although, yes, the performance is better using MeasureFirstItem, I have not achieved very high differences in my tests.

@hartez hartez added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Oct 31, 2019
@hartez
Copy link
Contributor

hartez commented Oct 31, 2019

@Clancey Which platform are we talking about here?

@hartez hartez moved this from New to Needs Info in Triage Oct 31, 2019
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2019
@samhouts samhouts added this to In Progress in v4.5.0 Nov 2, 2019
@samhouts samhouts removed this from Needs Info in Triage Nov 2, 2019
@davidortinau
Copy link
Contributor

@hartez he showed me iOS. This is the app: https://github.com/Clancey/gMusic.Forms

Repro video here: https://www.twitch.tv/videos/501788807

@samhouts samhouts removed s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/unverified New report that has yet to be verified labels Jan 3, 2020
@samhouts samhouts added this to Backlog in CollectionView Jan 3, 2020
@samhouts samhouts moved this from Backlog to In Progress in CollectionView Jan 3, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jan 7, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels May 15, 2020
@samhouts samhouts added a/performance and removed in-progress This issue has an associated pull request that may resolve it! labels May 26, 2020
@samhouts samhouts moved this from In Progress to Inactive in CollectionView May 26, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/collectionview a/performance help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
CollectionView
  
Inactive
v4.5.0
  
In Progress
v4.6.0
  
In Progress
5 participants