Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] [Android] Negative margins on Image not working from 4.4.x #9650

Open
roubachof opened this issue Feb 20, 2020 · 5 comments
Open

[Bug] [Android] Negative margins on Image not working from 4.4.x #9650

roubachof opened this issue Feb 20, 2020 · 5 comments

Comments

@roubachof
Copy link

Description

Since Xamarin.Forms version 4.4, negative margins aren't working anymore on Android.

Steps to Reproduce

  1. Clone https://github.com/roubachof/Sharpnado.TaskLoaderView
  2. Update XF package to 4.4 on all projects
  3. Launch Sample app on Android

Expected Behavior

The Image on each card should take all the width of the Frame cause of the negative horizontal margin:

<Image Grid.Row="2"
       Grid.Column="0"
       Grid.ColumnSpan="2"
       Margin="-15,0"
       Aspect="Fill"
       Source="{local:ImageResource Sample.Images.default_views.png}" />

Screenshot_1582205533

Actual Behavior

Negative horizontal margin is discarded:

margin_4 4

Basic Information

  • Version with issue: all versions since xf 4.4
  • Last known good version: 4.3.x

Reproduction Link

https://github.com/roubachof/Sharpnado.TaskLoaderView

Workaround

use XF 4.3.x

@roubachof roubachof added s/unverified New report that has yet to be verified t/bug 🐛 labels Feb 20, 2020
@pauldipietro pauldipietro added this to New in Triage Feb 20, 2020
@samhouts samhouts added this to the 4.4.0 milestone Feb 20, 2020
@samhouts samhouts added this to To do in v4.4.0 Feb 20, 2020
@PureWeen
Copy link
Contributor

Hmm the only changes I see to the image code between 4.3 and 4.4 are here

d012853#diff-3c9df6c0863723c3b3c1b7d9ebd32619

Seems like it's working fine on UWP

@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Feb 20, 2020
@PureWeen PureWeen moved this from New to Ready For Work in Triage Feb 20, 2020
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Feb 20, 2020
@samhouts samhouts added the 4.4.0 regression on 4.4.0 label Apr 14, 2020
@samhouts samhouts removed this from the 4.4.0 milestone Apr 17, 2020
@Druffl3
Copy link

Druffl3 commented May 13, 2020

To which milestone is this added? 4.6.0? I am on 4.5.0.725, and this issue still exists.

@roubachof
Copy link
Author

roubachof commented May 15, 2020

There is Goutham on the Xamarin slack that is reporting the same issue.

https://xamarinchat.slack.com/archives/C06BQCMK5/p1589366857287400

@roubachof roubachof changed the title [Bug] [Android] Negative margins not working on 4.4.x [Bug] [Android] Negative margins on Image not working from 4.4.x May 15, 2020
@Druffl3
Copy link

Druffl3 commented May 18, 2020

@roubachof , that's me only :P

@jbachelor
Copy link

I just ran into this issue as well on Android, using Xamarin.Forms 4.7.0.968.

@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Triage
  
Needs Estimate
v4.4.0
  
To do
Development

No branches or pull requests

5 participants