Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Enable Nullable for Xamarin.CommunityToolkit.Markup.UnitTests #1084

Closed
1 task done
brminnick opened this issue Mar 16, 2021 · 0 comments · Fixed by #1086
Closed
1 task done

[Enhancement] Enable Nullable for Xamarin.CommunityToolkit.Markup.UnitTests #1084

brminnick opened this issue Mar 16, 2021 · 0 comments · Fixed by #1086
Assignees
@brminnick
Labels
feature-request A request for a new feature. ♻ housekeeping This issue/PR is related to internal stuff.

Comments

@brminnick
Copy link
Contributor

Summary

This enhancement will enable Nullability for Xamarin.CommunityToolkit.Markup.UnitTests:

Note: Enabling WarningsAsErrors will allow our automated CI Tools to catch any possible null references/dereferences in future PRs

We enabled Nullable in #1009, but Xamarin.CommunityToolkit.Markup.UnitTests.csproj was overlooked.

Who Will Do The Work?

  • I am willing to take this on myself
@brminnick brminnick added the feature-request A request for a new feature. label Mar 16, 2021
@brminnick brminnick self-assigned this Mar 16, 2021
@brminnick brminnick added the ♻ housekeeping This issue/PR is related to internal stuff. label Mar 16, 2021
@brminnick brminnick mentioned this issue Mar 16, 2021
Merged
4 tasks
@brminnick brminnick linked a pull request Mar 16, 2021 that will close this issue
Enable Nullable for Xamarin.CommunityToolkit.Markup.UnitTests #1086
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brminnick brminnick

Labels
feature-request A request for a new feature. ♻ housekeeping This issue/PR is related to internal stuff.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Nullable for Xamarin.CommunityToolkit.Markup.UnitTests brminnick/XamarinCommunityToolkit
1 participant
@brminnick