Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Popup Fullscreen #1391

Closed
1 of 2 tasks
fredericoregateiro opened this issue Jun 12, 2021 · 6 comments
Closed
1 of 2 tasks

Popup Fullscreen #1391

fredericoregateiro opened this issue Jun 12, 2021 · 6 comments
Labels
a/popup feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before!

Comments

@fredericoregateiro
Copy link

Summary

Allow the Popup to be able to go full screen.

API Changes

Add one property to the Popup bool IsFullScreen, that allow the Popup to go fullscreen

Intended Use Case

Edit a record in a phone, will allow more space for the controls

Who Will Do The Work?

  • I am willing to take this on myself
  • Just putting this out there for someone to pick up
@fredericoregateiro fredericoregateiro added feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before! labels Jun 12, 2021
@pictos
Copy link
Contributor

pictos commented Jun 13, 2021

@fredericoregateiro I would say that if you need a full screen popup the best way is to perform a ModalNavigation. Or is there something that I can't see?

@jfversluis
Copy link
Member

I kind of agree with @pictos here. What would be the use-case? Why do you need this over a regular modal?

@ahoefling do you have any thoughts about this?

@SkyeHoefling
Copy link
Contributor

Not sure if I understand the use case here and I agree with @pictos. Do you have any screenshots of what you are thinking

@fredericoregateiro
Copy link
Author

fredericoregateiro commented Jun 14, 2021

Hello all,
In my opinion this is just a really nice feature for the pop up, and gives the developer the power of choice.
On the phone, screen size is something we should use with care. And the option to use all available space is something to consider.

And once i started using the popup and don't want to go back to the modal 😄

The problem for me is not the vertical space, but the horizontal.
Screenshot_1623676704

@fredericoregateiro
Copy link
Author

Similar to #1398
Making Margin="0" would be the same as Fullscreen="True" but with more control on how the popup is using the available screen size

@jfversluis
Copy link
Member

Hm to be honest I see more in the margin approach which gives more flexibility and control and might have a side-effect of being able to open a popup fullscreen :)

If you don't mind I'm closing this one in favor of #1398

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/popup feature-request A request for a new feature. needs-approval Feature request has been submitted but is awaiting final approval. Please do not implement before!
Projects
None yet
Development

No branches or pull requests

4 participants