Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

CxxBinder doesn't change string to SoundType for SoundSource and Audio #36

Closed
EgorBo opened this issue Jul 30, 2015 · 2 comments
Closed

Comments

@EgorBo
Copy link
Member

EgorBo commented Jul 30, 2015

Audio.GetMasterGain(string) => Audio.GetMasterGain(SoundType)
SoundSource.SetSoundType(string) => SoundSource.SetSoundType(SoundType)

it's still string despite of my changes to CxxBinder: c4121a2

@migueldeicaza
Copy link
Contributor

The issue is that the "currentParameterCount" should have been a zero.

That said, another fix that we have to do is turn the enums into C# like enums, so the use above of ToString() will not work once we go C#-names. So the right approach is to introduce an overload that takes an enum and passes constants based on it.

@migueldeicaza
Copy link
Contributor

Actually, your enums already matched the C# style, but they wont work.

Because the constants in C++ need to be "SOUND_MASTER", and not "Master". Not sure that it is worth to do reflection + ToUpper() + string concatenation. Instead, let us follow my suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants