Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentsProvider intent filter #2202

Closed
mbikovitsky opened this issue Sep 20, 2018 · 0 comments
Closed

DocumentsProvider intent filter #2202

mbikovitsky opened this issue Sep 20, 2018 · 0 comments
Assignees
@grendello
Labels
bug Component does not function as intended.
Milestone
d16-0

Comments

@mbikovitsky
Copy link

Steps to Reproduce

This is the same issue as here: IntentFilterAttribute is ignored on classes decorated with ContentProviderAttribute. The current workaround is to use RegisterAttribute on the DocumentsProvider subclass, which, as the documentation clearly states, is an ugly hack.

Expected Behavior

The intent-filter element is generated in the AndroidManifest.xml.

Actual Behavior

The intent-filter element is not generated in the AndroidManifest.xml.

Version Information

Xamarin   4.11.0.756 (d15-8@b66ff7180)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin.Android SDK   9.0.0.19 (HEAD/a8a3b0ec7)
Xamarin.Android Reference Assemblies and MSBuild support.
@mbikovitsky mbikovitsky changed the title Android DocumentsProvider intent filter DocumentsProvider intent filter Sep 20, 2018
@grendello grendello self-assigned this Sep 24, 2018
@grendello grendello added the bug Component does not function as intended. label Sep 24, 2018
@grendello grendello added this to the d16-0 milestone Sep 24, 2018
grendello added a commit to grendello/xamarin-android that referenced this issue Sep 25, 2018
@grendello
Don't ignore IntentFilter attribute on content provider classes
7c2c25b 
Fixes: dotnet#2202
Context: https://forums.xamarin.com/discussion/96028/android-documentsprovider-intent-filter

When generating `AndroidManifest.xml` we currently fail to take into account any
instances of the `IntentFilterAttribute` custom attribute decorating all the
content provider classes (that is ones with another custom attribute -
`ContentProviderAttribute`). This forces the developer to manually edit the
manifest to add appropriate entry for the provider and its intent filters.

This commit removes the limitation by making sure our manifest generator looks
for and processes the `IntentFilter` custom attribute.
@grendello grendello mentioned this issue Sep 25, 2018
Merged
dellis1972 pushed a commit that referenced this issue Oct 5, 2018
@grendello @dellis1972
Don't ignore IntentFilter attribute on content provider classes (#2222)
9a7e35e 
Fixes: #2202
Context: https://forums.xamarin.com/discussion/96028/android-documentsprovider-intent-filter

When generating `AndroidManifest.xml` we currently fail to take into account any
instances of the `IntentFilterAttribute` custom attribute decorating all the
content provider classes (that is ones with another custom attribute -
`ContentProviderAttribute`). This forces the developer to manually edit the
manifest to add appropriate entry for the provider and its intent filters.

This commit removes the limitation by making sure our manifest generator looks
for and processes the `IntentFilter` custom attribute.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grendello grendello

Labels
bug Component does not function as intended.
Projects
None yet
Milestone
d16-0
Development

No branches or pull requests
2 participants
@grendello @mbikovitsky