Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encountering linker failure on macOS on partial build after changing the project TargetFrameworkVersion #2584

Closed
pjcollins opened this issue Jan 3, 2019 · 4 comments · Fixed by #3405

Comments

@pjcollins
Copy link
Member

@pjcollins pjcollins commented Jan 3, 2019

I'm not sure if this particular scenario represents a "valid" bug per-say, but the behavior described below has started occurring somewhere between d15-9 and d16-0. This incremental build failure also only occurs when linking on macOS, and is not reproducible on Windows. Perhaps this is related to the difference in target framework versions of the app and library projects used in this repro (app currently targets v4.4 while the lib is targeting v8.1).

Steps to Reproduce

  1. Clone https://github.com/xamarin/monodroid-samples/tree/master/BatchStepSensor
  2. msbuild /t:SignAndroidPackage /p:Configuration=Release BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj
  3. msbuild /t:SignAndroidPackage /p:Configuration=Release BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj
  4. msbuild /t:SignAndroidPackage /p:TargetFrameworkVersion=v9.0 /p:Configuration=Release BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj

Expected Behavior

My third build attempt (which includes a property change) will succeed.

Alternatively, perhaps in this case the app framework version < lib framework version warning[0] just needs to be respected.
[0] warning XA0105: The $(TargetFrameworkVersion) for CommonSampleLibrary (v8.1) is greater than the $(TargetFrameworkVersion) for your project (v4.4). You need to increase the $(TargetFrameworkVersion) for your project.

Actual Behavior

/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018: The "LinkAssemblies" task failed unexpectedly. [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018: Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32) [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod (Mono.Cecil.MethodReference reference) [0x00013] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.MarkMethod (Mono.Cecil.MethodReference reference) [0x0004a] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.MarkInstruction (Mono.Cecil.Cil.Instruction instruction) [0x00040] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.MarkMethodBody (Mono.Cecil.Cil.MethodBody body) [0x00098] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.ProcessMethod (Mono.Cecil.MethodDefinition method) [0x00162] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets(2176,5): error MSB4018:   at Mono.Linker.Steps.MarkStep.ProcessQueue () [0x0001b] in <f427ee17a10d415c9af2d0abe8ab4b20>:0  [/Users/peter/source/monodroid-samples/BatchStepSensor/BatchStepSensor/BatchStepSensor.csproj]

Version Information

Visual Studio Enterprise 2017 for Mac
Version 7.7.2 (build 21)
Installation UUID: 57d9d5c5-f091-4a0a-af36-7330b1af94d2
GTK+ 2.24.23 (Raleigh theme)
Xamarin.Mac 4.4.1.178 (master / eeaeb7e6)
Package version: 518000225

Mono Framework MDK
Runtime:
Mono 5.18.0.225 (2018-08/bac9fc1f889) (64-bit)
Package version: 518000225

XA Version: 9.1.103.6 (Visual Studio Enterprise)

Log File

https://gist.githubusercontent.com/pjcollins/e915663f696828abaac25e66a1fa49ca/raw/1e48937f1543223975176ec676adc46fddc8dfc1/gistfile1.txt

@dellis1972

This comment has been minimized.

Copy link
Contributor

@dellis1972 dellis1972 commented Jan 28, 2019

This looks like we are not invalidating the linker cache when the build.props changes..
We should investigate this and fix for d16-1

@dellis1972 dellis1972 modified the milestones: d16-0, d16-1 Jan 28, 2019
@pjcollins pjcollins modified the milestones: d16-1, d16-3 Jun 7, 2019
@jonathanpeppers

This comment has been minimized.

Copy link
Member

@jonathanpeppers jonathanpeppers commented Jul 29, 2019

I could repro this on Windows when setting /p:AppendTargetFrameworkToIntermediateOutputPath=False, see:

<AppendTargetFrameworkToIntermediateOutputPath Condition=" '$(AppendTargetFrameworkToIntermediateOutputPath)' == '' And '$(OS)' == 'Windows_NT' ">True</AppendTargetFrameworkToIntermediateOutputPath>

So there is something wrong when bumping TFV's, we should fix this and test for it since it affects Mac users.

jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Jul 29, 2019
Fixes: xamarin#2584

Building a project with two different `$(TargetFrameworkVersion)`:

    msbuild /p:Configuration=Release /p:TargetFrameworkVersion=v4.4
    msbuild /t:Configuration=Release /p:TargetFrameworkVersion=v9.0

Results in a build error:

    error MSB4018: The "LinkAssemblies" task failed unexpectedly.
    Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32)
        at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
        at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
        at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        --- End of inner exception stack trace ---
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
        at Mono.Linker.Steps.MarkStep.Process()
        at MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
        at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
        at Mono.Linker.Pipeline.Process(LinkContext context)
        at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute()
        at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
        at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Which is due to an outdated `Mono.Android.dll` in the `obj` directory:

    Target Name=_CopyIntermediateAssemblies
        CopyIfChanged
        ...
        Skipping C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll its up to date
        ...
        ModifiedFiles:
            obj\Release\linksrc\BatchStepSensor.dll

Reviewing the `<CopyIfChanged/>` MSBuild task, there is a code path
where the copy is skipped if the source file is newer than the
destination.

In the case of modifying `$(TargetFrameworkVersion)` on an incremental
build, a *different* `Mono.Android.dll` would have an older timestamp.
The copy would be skipped.

A fix here is to *also* check the size of the source and destination
files, and only allow the copy to be skipped if the sizes match.
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Jul 30, 2019
Fixes: xamarin#2584

Building a project with two different `$(TargetFrameworkVersion)`:

    msbuild /p:Configuration=Release /p:TargetFrameworkVersion=v4.4
    msbuild /t:Configuration=Release /p:TargetFrameworkVersion=v9.0

Results in a build error:

    error MSB4018: The "LinkAssemblies" task failed unexpectedly.
    Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32)
        at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
        at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
        at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        --- End of inner exception stack trace ---
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
        at Mono.Linker.Steps.MarkStep.Process()
        at MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
        at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
        at Mono.Linker.Pipeline.Process(LinkContext context)
        at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute()
        at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
        at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Which is due to an outdated `Mono.Android.dll` in the `obj` directory:

    Target Name=_CopyIntermediateAssemblies
        CopyIfChanged
        ...
        Skipping C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll its up to date
        ...
        ModifiedFiles:
            obj\Release\linksrc\BatchStepSensor.dll

Reviewing the `<CopyIfChanged/>` MSBuild task, there is a code path
where the copy is skipped if the source file is newer than the
destination.

In the case of modifying `$(TargetFrameworkVersion)` on an incremental
build, a *different* `Mono.Android.dll` would have an older timestamp.
The copy would be skipped.

A fix here is to *also* check the size of the source and destination
files, and only allow the copy to be skipped if the sizes match.
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Jul 30, 2019
Fixes: xamarin#2584

Building a project with two different `$(TargetFrameworkVersion)`:

    msbuild /p:Configuration=Release /p:TargetFrameworkVersion=v4.4
    msbuild /t:Configuration=Release /p:TargetFrameworkVersion=v9.0

Results in a build error:

    error MSB4018: The "LinkAssemblies" task failed unexpectedly.
    Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32)
        at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
        at Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
        at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
        at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        --- End of inner exception stack trace ---
        at Mono.Linker.Steps.MarkStep.ProcessQueue()
        at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
        at Mono.Linker.Steps.MarkStep.Process()
        at MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
        at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
        at Mono.Linker.Pipeline.Process(LinkContext context)
        at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
        at Xamarin.Android.Tasks.LinkAssemblies.Execute()
        at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
        at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Which is due to an outdated `Mono.Android.dll` in the `obj` directory:

    Target Name=_CopyIntermediateAssemblies
        CopyIfChanged
        ...
        Skipping C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll its up to date
        ...
        ModifiedFiles:
            obj\Release\linksrc\BatchStepSensor.dll

Reviewing the `<CopyIfChanged/>` MSBuild task, there is a code path
where the copy is skipped if the source file is newer than the
destination.

In the case of modifying `$(TargetFrameworkVersion)` on an incremental
build, a *different* `Mono.Android.dll` would have an older timestamp.
The copy would be skipped.

A fix here is to *also* check the size of the source and destination
files, and only allow the copy to be skipped if the sizes match.

~~ _ConvertResourcesCases ~~

These changes surfaced a bug in the `_ConvertResourcesCases` target`,
if `build.props` changes then:

* The `_CompileResources` target runs
* `_ConvertResourcesCases` is skipped...

And you get a build error such as:

    Resources\layout\test.axml(3): error APT0000: resource drawable/IMALLCAPS (aka UnnamedProject.UnnamedProject:drawable/IMALLCAPS) not found.

The solution here is to make the `Inputs` of `_CompileResources` and
`_ConvertResourcesCases` the same. I also adjusted a test to check
both aapt and aapt2.
jonpryor added a commit that referenced this issue Aug 1, 2019
Fixes: #2584

Building a project with two different `$(TargetFrameworkVersion)`:

	msbuild /p:Configuration=Release /p:TargetFrameworkVersion=v4.4
	msbuild /t:Configuration=Release /p:TargetFrameworkVersion=v9.0

Results in a build error:

	error MSB4018: The "LinkAssemblies" task failed unexpectedly.
	Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32)
	    at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
	    at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
	    at Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
	    at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
	    at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
	    at Mono.Linker.Steps.MarkStep.ProcessQueue()
	    --- End of inner exception stack trace ---
	    at Mono.Linker.Steps.MarkStep.ProcessQueue()
	    at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
	    at Mono.Linker.Steps.MarkStep.Process()
	    at MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
	    at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
	    at Mono.Linker.Pipeline.Process(LinkContext context)
	    at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
	    at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
	    at Xamarin.Android.Tasks.LinkAssemblies.Execute()
	    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
	    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Which is due to an outdated `Mono.Android.dll` in the `obj` directory:

	Target Name=_CopyIntermediateAssemblies
	    CopyIfChanged
	    ...
	    Skipping C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll its up to date
	    ...
	    ModifiedFiles:
	        obj\Release\linksrc\BatchStepSensor.dll

Reviewing the `<CopyIfChanged/>` MSBuild task, there is a code path
where the copy is skipped if the source file is newer than the
destination.

In the case of modifying `$(TargetFrameworkVersion)` on an
incremental build, a *different* `Mono.Android.dll` would have an
older timestamp.  The copy would be skipped.

A fix here is to *also* check the size of the source and destination
files, and only allow the copy to be skipped if the sizes match.

~~ _ConvertResourcesCases ~~

These changes surfaced a bug in the `_ConvertResourcesCases` target`;
if `build.props` changes then:

  * The `_CompileResources` target runs
  * The `_ConvertResourcesCases` target is skipped (!)

And you get a build error such as:

	Resources\layout\test.axml(3): error APT0000: resource drawable/IMALLCAPS (aka UnnamedProject.UnnamedProject:drawable/IMALLCAPS) not found.

The solution here is to make the `Inputs` of `_CompileResources` and
`_ConvertResourcesCases` the same.  I also adjusted a test to check
both `aapt` and `aapt2`.
jonpryor added a commit that referenced this issue Aug 9, 2019
Fixes: #2584

Building a project with two different `$(TargetFrameworkVersion)`:

	msbuild /p:Configuration=Release /p:TargetFrameworkVersion=v4.4
	msbuild /t:Configuration=Release /p:TargetFrameworkVersion=v9.0

Results in a build error:

	error MSB4018: The "LinkAssemblies" task failed unexpectedly.
	Mono.Linker.MarkException: Error processing method: 'System.Void BatchStepSensor.BatchStepSensorFragment::OnSaveInstanceState(Android.OS.Bundle)' in assembly: 'BatchStepSensor.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void Android.OS.BaseBundle::PutInt(System.String,System.Int32)
	    at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
	    at Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
	    at Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
	    at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
	    at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
	    at Mono.Linker.Steps.MarkStep.ProcessQueue()
	    --- End of inner exception stack trace ---
	    at Mono.Linker.Steps.MarkStep.ProcessQueue()
	    at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
	    at Mono.Linker.Steps.MarkStep.Process()
	    at MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
	    at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
	    at Mono.Linker.Pipeline.Process(LinkContext context)
	    at MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
	    at Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
	    at Xamarin.Android.Tasks.LinkAssemblies.Execute()
	    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
	    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Which is due to an outdated `Mono.Android.dll` in the `obj` directory:

	Target Name=_CopyIntermediateAssemblies
	    CopyIfChanged
	    ...
	    Skipping C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll its up to date
	    ...
	    ModifiedFiles:
	        obj\Release\linksrc\BatchStepSensor.dll

Reviewing the `<CopyIfChanged/>` MSBuild task, there is a code path
where the copy is skipped if the source file is newer than the
destination.

In the case of modifying `$(TargetFrameworkVersion)` on an
incremental build, a *different* `Mono.Android.dll` would have an
older timestamp.  The copy would be skipped.

A fix here is to *also* check the size of the source and destination
files, and only allow the copy to be skipped if the sizes match.

~~ _ConvertResourcesCases ~~

These changes surfaced a bug in the `_ConvertResourcesCases` target`;
if `build.props` changes then:

  * The `_CompileResources` target runs
  * The `_ConvertResourcesCases` target is skipped (!)

And you get a build error such as:

	Resources\layout\test.axml(3): error APT0000: resource drawable/IMALLCAPS (aka UnnamedProject.UnnamedProject:drawable/IMALLCAPS) not found.

The solution here is to make the `Inputs` of `_CompileResources` and
`_ConvertResourcesCases` the same.  I also adjusted a test to check
both `aapt` and `aapt2`.
@brendanzagaeski

This comment has been minimized.

Copy link
Member

@brendanzagaeski brendanzagaeski commented Sep 4, 2019

Fix included in Xamarin.Android 10.0.0.40.

Fix included on Windows in Visual Studio 2019 version 16.3 Preview 3. To try the preview version that includes the fix, check for the latest updates in Visual Studio Preview.

Fix included on macOS in Visual Studio 2019 for Mac version 8.3 Preview 3. To try the preview version that includes the fix, check for the latest updates on the Preview updater channel.

@brendanzagaeski

This comment has been minimized.

Copy link
Member

@brendanzagaeski brendanzagaeski commented Sep 25, 2019

A new Release version has now been published that includes the fix for this item.

Fix included in Xamarin.Android 10.0.0.43

Fix included on Windows in Visual Studio 2019 version 16.3. To get the new version that includes the fix, check for the latest updates or install the latest version from https://visualstudio.microsoft.com/downloads/.

Fix included on macOS in Visual Studio 2019 for Mac version 8.3. To get the new version that includes the fix, check for the latest updates on the Stable updater channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.