Makefile tweaks #1870
Makefile tweaks #1870
Conversation
Makefile
Outdated
| for m in $BINFMT_MISC_TROUBLE; do \ | ||
| if [ -f /proc/sys/fs/binfmt_misc/$$m ]; then \ | ||
| for m in ${BINFMT_MISC_TROUBLE}; do \ | ||
| if [ -f "/proc/sys/fs/binfmt_misc/$m" ]; then \ |
Makefile
Outdated
| @@ -1,12 +1,12 @@ | |||
| export OS_NAME := $(shell uname) | |||
There was a problem hiding this comment.
I don't find it to be an "improvement" to have one export declaration for all variables instead of one per variable.
There was a problem hiding this comment.
it's personal preference but it makes the Makefile look more consistent at the start, besides exporting variables when they're not needed is also unnecessary. So should I revert this change or not?
There was a problem hiding this comment.
The only variable which doesn't appear to need the export is $(OS_NAME); both $(OS_ARCH) and $(NO_SUDO) may be used by child processes.
Revert the change; it won't matter if we export $(OS_NAME).
There was a problem hiding this comment.
Alright, reverted
Makefile
Outdated
| -mkdir -p "$(prefix)/lib/mono/xbuild-frameworks" | ||
| -mkdir -p "$(prefix)/lib/xamarin.android" | ||
| -mkdir -p "$(prefix)/lib/mono/xbuild/Xamarin/" | ||
| -mkdir -p "$(prefix)/bin" "$(prefix)/lib/mono/xbuild-frameworks" \ |
There was a problem hiding this comment.
I also don't find it to be an improvement to go from one directory per line to requiring \.
|
build |
No description provided.