[Xamarin.Android.Build.Tasks] use --input-list for CompileToDalvik.
#2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Sep 17, 2018
jonpryor
reviewed
Sep 17, 2018
jonpryor
reviewed
Sep 17, 2018
jonpryor
reviewed
Sep 17, 2018
| } | ||
| sw.WriteLine (zip); | ||
| foreach (var jar in JavaLibrariesToCompile) | ||
| sw.WriteLine (jar.ItemSpec); |
There was a problem hiding this comment.
Ditto here: do we need to quote the paths?
There was a problem hiding this comment.
Weird this is what happens on Mac if I quote the files in the input list
/usr/bin/java -Xmx1G -jar /Users/dean/android-toolchain/sdk/build-tools/28.0.0/lib/dx.jar --dex --no-strict --input-list=/var/folders/n_/vt_nzq1n04schx5yy2jgcgcw0000gn/T/tmp799bbfa5.tmp --output obj/Debug/android/bin
UNEXPECTED TOP-LEVEL EXCEPTION:
java.lang.RuntimeException: "/Users/dean/Documents/Sandbox/Xamarin/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v9.0/mono.android.jar": file not found
at com.android.dex.util.FileUtils.readFile(FileUtils.java:51)
at com.android.dx.cf.direct.ClassPathOpener.processOne(ClassPathOpener.java:168)
at com.android.dx.cf.direct.ClassPathOpener.process(ClassPathOpener.java:143)
at com.android.dx.command.dexer.Main.processOne(Main.java:678)
at com.android.dx.command.dexer.Main.processAllFiles(Main.java:575)
at com.android.dx.command.dexer.Main.runMonoDex(Main.java:310)
at com.android.dx.command.dexer.Main.runDx(Main.java:288)
at com.android.dx.command.dexer.Main.main(Main.java:244)
at com.android.dx.command.Main.main(Main.java:95)
This is the file
"/Users/dean/Documents/Sandbox/Xamarin/xamarin-android/bin/TestDebug/temp/BuildReleaseAppWithA InIt(FalseFalseFalse)/obj/Debug/android/bin/classes.zip"
"/Users/dean/Documents/Sandbox/Xamarin/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v9.0/mono.android.jar"
"/Users/dean/Documents/Sandbox/Xamarin/xamarin-android/bin/TestDebug/temp/BuildReleaseAppWithA InIt(FalseFalseFalse)/Hello (World).jar"
There was a problem hiding this comment.
So Mac does not like quotes... I will test on windows.
jonpryor
reviewed
Sep 17, 2018
| throw new FileNotFoundException ($"'{zip}' does not exist. Please rebuild the project."); | ||
| } | ||
| sw.WriteLine (zip); | ||
| foreach (var jar in JavaLibrariesToCompile) |
There was a problem hiding this comment.
Indentation/scope implies that you can't have both JavaLibrariesToCompile and AlternativeJarFiles at the same time. Is this intentional? Why?
There was a problem hiding this comment.
I have no idea, this is just a rework of the existing code. Will need to look at when AlternativeJarFiles were added.
jonpryor
reviewed
Sep 17, 2018
| } | ||
| sw.WriteLine (zip); | ||
| foreach (var jar in JavaLibrariesToCompile) | ||
| sw.WriteLine (jar.ItemSpec); |
There was a problem hiding this comment.
Should this be Path.GetFullPath (jar.ItemSpec)?
dellis1972
force-pushed
the
inputlist
branch
from
d0c6e07
to
78c9e19
Compare
|
@jonpryor OK so I tested the Input list on Windows. If you include Quotes you get the same error as you do on Mac Without Quotes, paths with spaces work fine. Here is a sample of the test one I used on Windows |
dellis1972
force-pushed
the
inputlist
branch
from
fc0652b
to
b9c5103
Compare
|
build |
1 similar comment
|
build |
jonathanpeppers
approved these changes
Sep 20, 2018
The `dx` tool has an additional argument `--input-list` which can be used to provide a list of `.jar`, `.class` or `.zip` files to the tool. This will help with reducing the length of the command line on larger apps with allot of jav references.
dellis1972
force-pushed
the
inputlist
branch
from
13cfef5
to
ed1bd8b
Compare
prash6001
reviewed
Dec 6, 2018
| @@ -47,6 +47,7 @@ | |||
| + [XA1000](xa1000.md): There was an problem parsing {file}. This is likely due to incomplete or invalid xml. | |||
| + [XA1001](xa1001.md): AndroidResgen: Warning while updating Resource XML '{filename}': {Message} | |||
| + [XA1002](xa1002.md): We found a matching key '{Key}' for '{Item}'. But the casing was incorrect. Please correct the casing | |||
There was a problem hiding this comment.
After upgrading a visual studio i am getting this error in all of the xml for namespace.
There was a problem hiding this comment.
@prash6001 can you open an issue and provide Diagnostic build logs so someone can give you a had to narrow down the cause.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dxtool has an additional argument--input-listwhichcan be used to provide a list of
.jar,.classor.zipfiles to the tool.
This will help with reducing the length of the command line
on larger apps with allot of java references.