Bump to xamarin/Java.Interop/master@706e4cc4 #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `Java.Interop.JniRuntime.CreationOptions.UseMarshalMemberBuilder` property which controls whether or not `Java.Interop.Export.dll` is loaded during `JniRuntime` creation. Xamarin.Android currently doesn't build, bundle, or otherwise include `Java.Interop.Export.dll`, and thus the attempted assembly load *always fails*, which is "fine" -- the exception is handled appropriately -- but attempted load and corresponding exception appears to add about ~100ms to process startup, which is insane. Set `JniRuntime.CreationOptions.UseMarshalMemberBuilder=false` so that we don't attempt to load this assembly, which should help our process startup times.
grendello
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Java.Interop.JniRuntime.CreationOptions.UseMarshalMemberBuilderproperty which controls whether or not
Java.Interop.Export.dllisloaded during
JniRuntimecreation.Xamarin.Android currently doesn't build, bundle, or otherwise include
Java.Interop.Export.dll, and thus the attempted assembly loadalways fails, which is "fine" -- the exception is handled
appropriately -- but attempted load and corresponding exception
appears to add about ~100ms to process startup, which is insane.
Set
JniRuntime.CreationOptions.UseMarshalMemberBuilder=falseso thatwe don't attempt to load this assembly, which should help our process
startup times.