[Xamarin.Android.Build.Tasks] more logging in <BuildApk/> #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
May 23, 2019
Context: https://github.com/xamarin/xamarin-android/blob/373c6ed08bef01274bd4abfe330d50327052e067/src/Xamarin.Android.Build.Tasks/Tasks/BuildApk.cs#L195 Context: https://github.com/xamarin/xamarin-android/blob/373c6ed08bef01274bd4abfe330d50327052e067/src/Xamarin.Android.Build.Tasks/Utilities/Files.cs#L271 Testing locally, code changes were not making it onto my device... Reviewing the build logs: 1. `_CopyPackage` was skipped 2. `CopyIfZipChanged` was returning `false` 3. The `CRC` values of each item in the APK was reporting `0`??? I decided to nuke my build tree with `git clean -dxf` and rebuild. Then it worked fine... I must have had an outdated `libzip.dll` that was broken? This makes me nervous, but there is something to improve here. There was not really sufficient logging for me to understand what happened without making code changes to the MSBuild tasks. So I think it is a good idea to log the result of `CopyIfZipChanged`, if we need to review what is happening from customer build logs in the future. I also refactored the code in `<BuildApk/>` slightly, and I removed a commented out `Console.WriteLine()`.
jonathanpeppers
force-pushed
the
buildapk-logging
branch
from
1c0fa1b
to
5c20f99
Compare
|
1,113 failures from Let's rebuild anyway, cross our fingers 🤞, and hope we don't get rando failures next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-android/blob/373c6ed08bef01274bd4abfe330d50327052e067/src/Xamarin.Android.Build.Tasks/Tasks/BuildApk.cs#L195
Context: https://github.com/xamarin/xamarin-android/blob/373c6ed08bef01274bd4abfe330d50327052e067/src/Xamarin.Android.Build.Tasks/Utilities/Files.cs#L271
Testing locally, code changes were not making it onto my device...
Reviewing the build logs:
_CopyPackagewas skippedCopyIfZipChangedwas returningfalseCRCvalues of each item in the APK was reporting0???I decided to nuke my build tree with
git clean -dxfand rebuild.Then it worked fine... I must have had an outdated
libzip.dllthatwas broken?
This makes me nervous, but there is something to improve here.
There was not really sufficient logging for me to understand what
happened without making code changes to the MSBuild tasks. So I think
it is a good idea to log the result of
CopyIfZipChanged, if we needto review what is happening from customer build logs in the future.
I also removed a commented out
Console.WriteLine().