Fix fastdev library side loading #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
added
the
full-mono-integration-build
grendello
force-pushed
the
fix-fastdev
branch
from
4cfe903
to
1ea6cf2
Compare
grendello
force-pushed
the
fix-fastdev
branch
6 times, most recently
from
6b78b0a
to
ba58934
Compare
pjcollins
reviewed
Nov 19, 2019
jonpryor
reviewed
Nov 19, 2019
grendello
force-pushed
the
fix-fastdev
branch
from
ba58934
to
bae0dec
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
fix-fastdev
branch
2 times, most recently
from
2a5f0ad
to
c8b1e6e
Compare
Override directories must be set up both in the debug app helper and the monodroid runtime as both of them are loaded separately and they do not depend on each other. This fixes loading of the side loaded shared libraries from the internal location where they are copied from the override directories. Add a pipeline step to run tests with fast dev enabled
grendello
force-pushed
the
fix-fastdev
branch
from
c8b1e6e
to
ab47a74
Compare
dellis1972
approved these changes
Nov 20, 2019
jonathanpeppers
approved these changes
Nov 20, 2019
pjcollins
approved these changes
Nov 20, 2019
|
So the Mac error is interestingly there is a warning further up Which is new. I wonder if this Microsoft version of java has been hardened for FIPS like we had too, or has had something else done to it. |
|
I've been seeing that ANDKT0000 error a lot of late. I'd love to know why. |
jonpryor
reviewed
Nov 21, 2019
|
|
||
| for (uint32_t i = 0; i < BasicAndroidSystem::MAX_OVERRIDES; ++i) { | ||
| const char *p = androidSystem.get_override_dir (i); | ||
| if (!utils.directory_exists (p)) |
There was a problem hiding this comment.
This is slightly concerning, in that it's imaginable that externalStorageDirs may be null at some point -- especially when we're looking into shared runtime removal/etc. -- in which case it's imaginable that p will be nullptr here, which would (eventually) result in stat(nullptr, &buf), which is....probably "fine"? But not desirable?
Check if override directory is null before passing it to `stat`
jonpryor
pushed a commit
that referenced
this pull request
Nov 27, 2019
Override directories must be set up in both `libxamarin-debug-app-helper.so` and `libmonodroid.so`, as both of them are loaded separately and they do not depend on each other. This fixes loading of the side loaded shared libraries from the internal location where they are copied from the override directories. Add a pipeline step to run tests with `$(AndroidFastDeploymentType)` set to `Assemblies:Dexes`, which should side-load native libs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override directories must be set up both in the debug app helper and the
monodroid runtime as both of them are loaded separately and they do not depend
on each other. This fixes loading of the side loaded shared libraries from the
internal location where they are copied from the override directories.