[Mono.Android] Remove problematic default interface method Cursor.getNotificationUris. #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NotificationUris.
jonpryor
pushed a commit
that referenced
this pull request
Oct 12, 2020
Fixes: #5027 Context: dotnet/java-interop#699 Context: dotnet/java-interop#699 (comment) Context: eadd3bd The [`Cursor.getNotificationUris()`][0] interface default method was added in API-29. Much as with `Cursor.setNotificationUris()` and commit eadd3bd, this introduces an issue when implementing `Android.Database.ICursor` in API-30+: when binding a Java class that implements `Cursor`: // Java public class MyCursor implements android.database.Cursor { // … } In the binding `generator` emits for `MyCursor`, the Java-to-managed marshal method to support `Cursor.getNotificationUris()` does not compile, as it tries to use a generic type -- `IList<T>` -- without providing any generic type parameters: // C# binding public partial class MyCursor : Java.Lang.Object, ICursor { static IntPtr n_GetNotificationUris (IntPtr jnienv, IntPtr native__this) { var __this = Java.Lang.Object.GetObject<MyCursor> (jnienv, native__this, JniHandleOwnership.DoNotTransfer); return global::Android.Runtime.JavaList.ToLocalJniHandle (__this.NotificationUris);; // ^^ error CS1503: Argument 1: cannot convert from 'System.Collections.Generic.IList<Android.Net.Uri>' to 'System.Collections.IList?' } } We had thought that dotnet/java-interop@262743b47 addressed this issue, but we were mistaken. The `generator` fix for this scenario seems tricky, so as a workaround for now we can simply remove the `Cursor.getNotificationUris()` default method so users can implement the interface. (Although the method was added in API-29, we don't support Default Interface Members in API-29, so it was ignored. Thus, this problem doesn't show up until API-30+ is used.) [0]: https://developer.android.com/reference/android/database/Cursor#getNotificationUris()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#699
In #5124 we removed
Cursor.setNotificationUris (...)because it causes binding problems when it is overridden.Cursor.getNotificationUris ()was not removed because it was believed that the issue was confined to parameters, however it affects return values as well.Remove default interface method
Cursor.getNotificationUris ()untilgeneratorcan be properly fixed.