Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MXE build of libzip #868

Closed
wants to merge 1 commit into from
Closed

Conversation

grendello
Copy link
Contributor

Commit fa9f62a failed to update the MXE build of the library
and so it was still being built as a static archive (which is the
new libzip default) and caused build failures when building
libzip executables.

This commit makes MXE build a shared version of the library and,
hopefully, fixes the issue.

Commit dotnet@fa9f62a failed to update the MXE build of the library
and so it was still being built as a static archive (which is the
new libzip default) and caused build failures when building
libzip executables.

This commit makes MXE build a shared version of the library and,
hopefully, fixes the issue.
@jonpryor jonpryor added the full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps) label Sep 18, 2017
@jonpryor
Copy link
Member

macOS+xbuild still fails:

Linking C executable hole.exe
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x77): undefined reference to `__imp_zip_error_init'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x9b): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0xcf): undefined reference to `__imp_zip_error_fini'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0xf5): undefined reference to `__imp_zip_error_init'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x106): undefined reference to `__imp_zip_source_file_create'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x11d): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x151): undefined reference to `__imp_zip_error_fini'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x17d): undefined reference to `__imp_zip_source_open'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x18e): undefined reference to `__imp_zip_source_begin_write'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x1a2): undefined reference to `__imp_zip_source_read'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x1a9): undefined reference to `__imp_zip_source_write'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x1e0): undefined reference to `__imp_zip_source_close'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x1e9): undefined reference to `__imp_zip_source_commit_write'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x20e): undefined reference to `__imp_zip_source_error'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x217): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x246): undefined reference to `__imp_zip_source_close'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x24f): undefined reference to `__imp_zip_source_rollback_write'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x25a): undefined reference to `__imp_zip_source_error'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x263): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x28f): undefined reference to `__imp_zip_source_error'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x298): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x2cf): undefined reference to `__imp_zip_source_error'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x2d8): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x307): undefined reference to `__imp_zip_source_close'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x318): undefined reference to `__imp_zip_source_error'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x321): undefined reference to `__imp_zip_error_strerror'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text+0x350): undefined reference to `__imp_zip_source_rollback_write'
CMakeFiles/hole.dir/objects.a(hole.c.obj):hole.c:(.text.startup+0xb3): undefined reference to `__imp_zip_source_free'
CMakeFiles/hole.dir/objects.a(source_hole.c.obj):source_hole.c:(.text+0x95): undefined reference to `__imp_zip_error_to_data'
CMakeFiles/hole.dir/objects.a(source_hole.c.obj):source_hole.c:(.text+0xa9): undefined reference to `__imp_zip_error_fini'
CMakeFiles/hole.dir/objects.a(source_hole.c.obj):source_hole.c:(.text+0x169): undefined reference to `__imp_zip_source_seek_compute_offset'
...

What's weird is that this fails after 3h50min: libzip and company are built for the Debug configuration, but not for the Release configuration.

@jonpryor
Copy link
Member

In the meantime, I'm reverting PR #863 so that we get get master green again, and resume merging PRs.

@grendello
Copy link
Contributor Author

New PR opened which combines both *nix and Windows changes (and hopefully fixes the build): #874

@grendello grendello closed this Sep 19, 2017
@grendello grendello deleted the libzip-fix-win branch September 19, 2017 11:36
jonpryor pushed a commit that referenced this pull request Sep 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants