Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

iOS linker not removing unused class if it inherits from UIView #7429

Closed
PureWeen opened this issue Sep 4, 2019 · 6 comments
Closed

iOS linker not removing unused class if it inherits from UIView #7429

PureWeen opened this issue Sep 4, 2019 · 6 comments

Comments

@PureWeen
Copy link
Contributor

PureWeen commented Sep 4, 2019

Anything inheriting from NSObject won't get linked out

@swansca79
Copy link

*Actual Behavior, link out WebViewRenderer ?

@PureWeen
Copy link
Contributor Author

PureWeen commented Sep 4, 2019

@swansca79 eventually yes but with how the included binaries (and our nuget packages) are setup it should be linking out WkWebViewRenderer if you aren't using it. So in the issue I'm just indicating my expectations given the included project. If those expectations get resolved then we can apply those to WebViewRenderer by making WkWebViewRenderer the default.

@chamons chamons transferred this issue from xamarin/xamarin-macios Sep 6, 2019
@whitneyschmidt
Copy link

Renderers are a Xamarin Forms concept so their linking behavior probably needs to be looked at by the Forms team first?

@chamons
Copy link

chamons commented Sep 6, 2019

@samhouts ^?

@samhouts
Copy link
Member

samhouts commented Sep 6, 2019

@whitneyschmidt @chamons Hey! Yeah, we are the Forms team....so we were asking for some help investigating this issue. :)

@chamons
Copy link

chamons commented Sep 6, 2019

I missed the fact that the reporter was Shawn (GH name did not match expectations).

I talked to him over slack, and he has a few things to check and then will slap it back to us. :)

@PureWeen PureWeen changed the title iOS linker not removing unused class inside SDK unlike Android iOS linker not removing unused class if it inherits from UIView Sep 7, 2019
@PureWeen PureWeen closed this as completed Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants