Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google maps section in Articles #33

Merged
merged 6 commits into from Feb 13, 2019

Conversation

dev-aritra
Copy link
Contributor

✏️ Section: Articles

By sending this pull request to contribute I verify that I adhere to the Xamarin Universal Library guidelines:

  • The pull request adheres to the repository's Code of Conduct.
  • I have followed the section's Contributing Guidelines.
  • I understand, Titles should be capitalized. I have checked the grammar.
  • I have searched for previous suggestions before making this new one, as mine could be a duplicate.
  • I understand, my contribution may be removed at any time if any of these guidelines are broken.
  • The submitted contribution is not owned by a company which sole purpose it is to advertise a product of product line.

Only the collaborators of this repository decide whether a contribution is eligible or not. They will determine if the rules are followed and if the quality of the content is high enough.

Opening another PR, after the first one is closed in a small period of time will not be reevaluated. If a PR is closed, the issues with your contribution are too significant to be fixed within a matter of hours.

@dev-aritra dev-aritra changed the title Google maps Added Google maps section in Articles Feb 13, 2019
@wcoder wcoder self-requested a review February 13, 2019 19:13
Copy link
Member

@wcoder wcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for contributing!

I think Google Maps isn't a common section.
Could you please think about the different name of the section?
For example: Maps

@dev-aritra
Copy link
Contributor Author

@wcoder Yeah I was thinking the same, but then thought does anybody uses apple maps/ bing maps these days. What do you say?

@wcoder
Copy link
Member

wcoder commented Feb 13, 2019

@dev-aritra I know about using Carto, Mapbox, MapKit with Xamarin, maybe in future be good articles about these maps.

@dev-aritra
Copy link
Contributor Author

@wcoder Yeah that sounds right. So, for now, shall I just rename the section to be Maps, and later on when we have articles from different categories of maps, then we would create subsections inside the map section?

@wcoder
Copy link
Member

wcoder commented Feb 13, 2019

@wcoder Yeah that sounds right. So, for now, shall I just rename the section to be Maps, and later on when we have articles from different categories of maps, then we would create subsections inside the map section?

Yes

Also, please fix the title and description of the section.

@dev-aritra
Copy link
Contributor Author

@wcoder cool, will make the changes and comment then. Thanks for the guidance.

@dev-aritra
Copy link
Contributor Author

@wcoder please check now.

src/articles/README.md Outdated Show resolved Hide resolved
@wcoder wcoder merged commit 087b675 into xamarinuniverse:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants