Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will HDR brightness control be added? #687

Closed
Askejm opened this issue Nov 6, 2023 · 8 comments
Closed

When will HDR brightness control be added? #687

Askejm opened this issue Nov 6, 2023 · 8 comments

Comments

@Askejm
Copy link

Askejm commented Nov 6, 2023

Works fine on my SDR monitor, but on my HDR monitor the brightness slider does nothing

@xanderfrangos
Copy link
Owner

HDR in Windows is a mess, and HDR brightness control over DDC/CI seems to vary per monitor (if it's even supported on a given monitor at all). There's unlikely to ever to be a one-size-fits-all solution. I don't own a true HDR monitor, so I don't have a good device to test with. It's also not a huge priority for me at the moment. Maybe once I finally get v1.16.0 I can give it another look.

See issue #97 for more info.

I'm going to close this issue in favor of the issue linked above.

@Askejm
Copy link
Author

Askejm commented Nov 9, 2023

alright the monitor I got is aw3423dwf id be willing to test if needed

@xanderfrangos
Copy link
Owner

@Askejm The most useful thing would be to see if there's a VCP code for your monitor that controls HDR brightness using a tool like ControlMyMonitor. 0x10 is likely SDR brightness. If your monitor supports adjusting HDR brightness over DDC/CI, I can add your model to it as a feature eventually. And at the bare minimum, you would be able to add support yourself in v1.16.0, since custom VCP code sliders are a feature there.

@Askejm
Copy link
Author

Askejm commented Nov 9, 2023

@xanderfrangos Alright I downloaded controlmymonitor. These are the values:
image
As you mentioned, 0x10 is the SDR brightness. When I have HDR off I can control it just fine but with it on, that value does nothing.
My monitor says it supports DDC/CI, but I'm not sure if any of these values would be HDR brightness. Do you have any ideas?

@Askejm
Copy link
Author

Askejm commented Nov 9, 2023

Actually, after messing around with the manufacturer specific sliders. It seems E0 is a toggle between normal and reduced brightness.
Here is what the others do if you or anyone else would be curious:

  • E1 starts pixel refresh
  • E2 does nothing
  • E3 does nothing
  • E5 does nothing
  • E6 does nothing
  • E7 does nothing
  • EC changes toggles presets
  • ED does nothing
  • F0 changes color preset mode (unavailable in HDR)
  • F1 does nothing
  • F2 does nothing
  • F4 toggles a bunch of modes like 1 hour timer, display alignment, displaying Hz etc.
  • FD does nothing

I imagine most of these don't do anything because I have HDR enabled.

@xanderfrangos
Copy link
Owner

@Askejm That's unfortunately not surprising. I don't think many monitors will offer HDR brightness over DDC. And from the PDF you linked, it doesn't seem like the OSD even has HDR brightness controls (like with SDR). Unless it shares the SDR slider.

@Askejm
Copy link
Author

Askejm commented Nov 9, 2023

@xanderfrangos Rip, that sucks. I will just have to make do with E0 then when 1.16 releases. I have also found that contrast can change brightness, which was what I did before.

@Askejm
Copy link
Author

Askejm commented Dec 9, 2023

@xanderfrangos I just realized
image
This setting is what controls the brightness on my HDR monitor. The HDR monitor just gets told by windows how many nits to display. So would it be possible to have the sliders change this value? That would be really practical. It's in system>display>hdr>SDR content brightness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants