Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the change to project member accepting ISO time #1638

Merged

Conversation

PatrickRice-KSC
Copy link
Contributor

@PatrickRice-KSC PatrickRice-KSC commented Jan 30, 2023

Closes #1637

This reverts a change from ISOTime -> time.Time type within the ProjectMembers struct. This revert fixes a breaking change, that being that ISOTime can accept YYYY-MM-DD format dates, whereas time.Time requires a full DateTime object.

With that breaking change in place, any consumer who is relying on the time suffix not being present would break.

@PatrickRice-KSC
Copy link
Contributor Author

I think this should be a simple review since it's just a reversion @svanharmelen 😞

Happy to chat about alternative methods, but there wasn't a lot of chatter on the issue from the original contributor, and I wanted to fix this soon-ish so other consumers don't accidentally break if they use this feature.

@svanharmelen
Copy link
Member

Thanks @PatrickRice-KSC for the updates and explanations... I'll merge this one and release a new version...

@svanharmelen svanharmelen merged commit 4620d0f into xanzy:master Jan 30, 2023
@svanharmelen
Copy link
Member

Tagged version v0.79.1 Guess I didn't take enough time to fully understand the change in relation to how the API actually handles this field. Bit annoying that the API handles it like this and that we need two different time types for different parts of the API, but looks like this is the better solution for this one 👍🏻

@PatrickRice-KSC
Copy link
Contributor Author

Yeah, I agree completely. I'm going to see if I can make a documentation update on the GitLab side as well, because a lot of their examples have DateTime objects, even though only the Date precision is used. I suspect that's behind a lot of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert the change to ProjectMembers API accepting a Time object - Update to accept ISO Time
2 participants