Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty and test #1665

Merged

Conversation

PatrickRice-KSC
Copy link
Contributor

Closes #1664

This updates one optional project attribute to use omitempty, and creates one test to ensure that marshalling the object with that attribute not set doesn't include that tag anymore :)

Copy link
Contributor

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @PatrickRice-KSC !

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRice-KSC 👍🏻

@svanharmelen svanharmelen merged commit 40e5bfd into xanzy:master Mar 8, 2023
@PatrickRice-KSC PatrickRice-KSC deleted the add-omit-empty-to-project-options branch March 8, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Project Value causes issue when null
3 participants