Add support for Group Protected Environments #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beekeep
force-pushed
the
feat/group-protected-envs
branch
4 times, most recently
from
48ab504
to
efa6c1d
Compare
Add support for Group Protected Environments, similar to Project Protected Environments.
beekeep
force-pushed
the
feat/group-protected-envs
branch
from
efa6c1d
to
e083b13
Compare
|
@svanharmelen This is ready for your review. |
svanharmelen
approved these changes
Sep 2, 2023
|
@svanharmelen Thanks for the review. I had the initial thought of re-using the project protected environment structs, but I wasn't sure if it would be better to create structs specific to groups, in case they do change in projects. In the future, would you prefer re-use if the structs are the same? |
|
I don't know... Generally I prefer to re-use structs if it makes sense, but in this case I think this is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Group Protected Environments, similar to Project Protected Environments.
https://docs.gitlab.com/ee/api/group_protected_environments.html