Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sm works with IPv6 #527

Closed
benjamreis opened this issue Nov 27, 2020 · 12 comments
Closed

Make sm works with IPv6 #527

benjamreis opened this issue Nov 27, 2020 · 12 comments

Comments

@benjamreis
Copy link
Contributor

Hi all!

I'm trying to play with IPv6 and I'm facing issues when adding a NFS SR on an IPv6 only pool. Is it currently supported?
If not, what needs to be done?

Here's the error I'm facing:
SR_BACKEND_FAILURE_1200(, not all arguments converted during string formatting, )

@MarkSymsCtx
Copy link
Contributor

There is no support for IPV6 anywhere in the control domain of the hypervisor.

@benjamreis
Copy link
Contributor Author

I've made some contributions in xcp-networkd and xen-api to enhance IPv6 support.
I'm experimenting with it right now and have 2 hosts in an IPv6 only pool with many things working so I'm assuming that you're specifically speaking about SMAPI, is that correct?

Do you have an estimation of the work needed to support IPv6? We are willing to help. :)

@MarkSymsCtx
Copy link
Contributor

Last estimate was something like 5 man years IIRC.

@edwintorok
Copy link
Contributor

edwintorok commented Nov 27, 2020

It would be good to improve the error message when trying to use IPv6, instead of getting an internal python error about string formatting. E.g. something simple like "IPv6 not supported yet for storage interfaces"

@olivierlambert
Copy link

olivierlambert commented Nov 27, 2020

5 man years to do what exactly? In SMAPI or in the whole platform? We are not that far to get everything else working (XAPI is almost OK after few PRs, a lot of things are already working).

If it's "just" parsing in SMAPIv1 for few drivers (network SRs) we are willing to improve them. If it's something else we can't see right now, we'll be happy to understand where's the most difficult part :)

@MarkSymsCtx
Copy link
Contributor

The platform.

@MarkSymsCtx
Copy link
Contributor

Big enough and requiring enough testing that our product managers have consistently said no, not happening even though we have customers asking for it.

@olivierlambert
Copy link

Can you be more specific about which component? From what I'm seeing:

  • XAPI (I think we aren't far to get everything done)
  • Python install to choose an IPv6 (only minor modification, because the answer file is already capable of eating v6 addresses)
  • SMAPIv1 (parsing correctly IPv6 addresses for NFS/iSCSI, anything else?)
  • What else?

@olivierlambert
Copy link

FYI we did release a first ISO with IPv6 support (with 3 modes: IPv4 only/IPv6 only/dual stack). See https://xcp-ng.org/blog/2021/02/09/ipv6-in-xcp-ng/

We'll take a look at SMAPIv1 at least for NFS and iSCSI. @MarkSymsCtx is there any other drivers that would require changes in your opinion?

@olivierlambert
Copy link

Okay so LVMoiSCSI is already working in IPv6 only 🥳

So there only #547 to merge to get NFS in IPv6 and we are done 👍

@olivierlambert
Copy link

I'm a bit late but since #547 is merged, we should close this.

@benjamreis
Copy link
Contributor Author

indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants